Closed
Bug 1041566
Opened 10 years ago
Closed 10 years ago
Lightning 3.5 broken with 2014-07-21 update
Categories
(Calendar :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
3.3.1
People
(Reporter: bc, Assigned: Fallen)
Details
(Keywords: regression)
Attachments
(1 file)
1.20 KB,
patch
|
ssitter
:
review+
Fallen
:
approval-calendar-aurora+
Fallen
:
approval-calendar-beta+
|
Details | Diff | Splinter Review |
After updating Thunderbird Daily 2014-07-21 and finding the Lightning 3.5a1 update applied, I can no longer open the Today Pane. The Error console shows Error: classInfo.interfaces is undefined Source File: resource://gre/modules/XPCOMUtils.jsm Line: 136 Error: NS_ERROR_XPC_GS_RETURNED_FAILURE: Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService] Source File: resource://calendar/modules/calUtils.jsm Line: 16
Reporter | ||
Updated•10 years ago
|
Version: unspecified → Lightning 3.5
Assignee | ||
Comment 1•10 years ago
|
||
I haven't actually tested this, but I assume its because of these two typos. I hope it doesn't cause issues on Lightning 3.3, but given its been "working" before it should be fine on those branches. Bob, can you test this patch, or do you need an xpi to give it a try?
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #8459682 -
Flags: review?(matthew.mecca)
Comment 2•10 years ago
|
||
Comment on attachment 8459682 [details] [diff] [review] Fix - v1 fixes the problem for me on Windows platform, r=ssitter
Attachment #8459682 -
Flags: review?(matthew.mecca) → review+
Reporter | ||
Comment 3•10 years ago
|
||
Philipp, I edited the files directly in my profile and the today pane works for me.
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8459682 [details] [diff] [review] Fix - v1 Approving for aurora and beta after the merge. Will set checkin-needed because the trees are only semi-open.
Attachment #8459682 -
Flags: approval-calendar-beta+
Attachment #8459682 -
Flags: approval-calendar-aurora+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 5•10 years ago
|
||
I think the bustage - or rather making the Lightning error visible - was caused by check-in for Bug 1039162.
Assignee | ||
Comment 6•10 years ago
|
||
Pushed to comm-central changeset 8926fb06f635
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.5
Assignee | ||
Comment 7•10 years ago
|
||
Backported to releases/comm-aurora changeset f5a6cda17edf
Target Milestone: 3.5 → 3.4
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 8•10 years ago
|
||
The problem also exists on http://mxr.mozilla.org/comm-release/search?string=interaces Maybe we should fix it there too in case we will do an 3.3.* release.
Assignee | ||
Comment 9•10 years ago
|
||
Yes, we should pick this up for 3.3.x if such a release is needed. Might as well push this to comm-release so its picked up automatically. https://hg.mozilla.org/releases/comm-release/rev/2ded2e83d74f
Target Milestone: 3.4 → 3.3.1
You need to log in
before you can comment on or make changes to this bug.
Description
•