1041566 - Lightning 3.5 broken with 2014-07-21 update

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Bob Clary [:bc] (inactive)]

After updating Thunderbird Daily 2014-07-21 and finding the Lightning 3.5a1 update applied, I can no longer open the Today Pane. The Error console shows

Error: classInfo.interfaces is undefined
Source File: resource://gre/modules/XPCOMUtils.jsm
Line: 136

Error: NS_ERROR_XPC_GS_RETURNED_FAILURE: Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]
Source File: resource://calendar/modules/calUtils.jsm
Line: 16

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

I haven't actually tested this, but I assume its because of these two typos. I hope it doesn't cause issues on Lightning 3.3, but given its been "working" before it should be fine on those branches.

Bob, can you test this patch, or do you need an xpi to give it a try?

Comment 2

[Stefan Sitter [:ssitter]]

Comment on attachment 8459682 [details] [diff] [review]
Fix - v1

fixes the problem for me on Windows platform, r=ssitter

Comment 3

[Bob Clary [:bc] (inactive)]

 Philipp, I edited the files directly in my profile and the today pane works for me.

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8459682 [details] [diff] [review]
Fix - v1

Approving for aurora and beta after the merge. Will set checkin-needed because the trees are only semi-open.

Comment 5

[Stefan Sitter [:ssitter]]

I think the bustage - or rather making the Lightning error visible - was caused by check-in for Bug 1039162.

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central changeset 8926fb06f635

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Backported to releases/comm-aurora changeset f5a6cda17edf

Comment 8

[Stefan Sitter [:ssitter]]

The problem also exists on http://mxr.mozilla.org/comm-release/search?string=interaces

Maybe we should fix it there too in case we will do an 3.3.* release.

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Yes, we should pick this up for 3.3.x if such a release is needed. Might as well push this to comm-release so its picked up automatically.

https://hg.mozilla.org/releases/comm-release/rev/2ded2e83d74f