Closed Bug 1041618 Opened 5 years ago Closed 5 years ago

Enable history search on master

Categories

(Firefox OS Graveyard :: Gaia::Search, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: daleharvey, Unassigned)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

No description provided.
Probably in search
Component: Gaia::System::Browser Chrome → Gaia::Search
Depends on: 968156
No longer depends on: 968156
Depends on: 968156
See Also: → 1041985
Duplicate of this bug: 1041985
I have a patch in progress here: https://github.com/mozilla-b2g/gaia/pull/22024

Not sure if I will continue to work on this or not though as I'm not sure if we can turn this on yet due to the whole MozActivity thing. Let's discuss options today.
Hey - can you guys review this? I understand that we may want to block this until we have the icon sizes list fixed, in the meantime I think we should have this reviewed so we can be ready to go.

Also we may consider just wiping the places DB before launch, so maybe it's not a big deal to land early?
Attachment #8460161 - Flags: review?(dale)
Attachment #8460161 - Flags: review?(21)
So https://bugzilla.mozilla.org/show_bug.cgi?id=968156 is the bug I wanna block this on, its in review but data storage format has changed several times so would definitely prefer it to land prior to this, the places db is never persisted, but the datastore is

Checking this out now though, can review and land straight after
Comment on attachment 8460161 [details] [review]
Pull request - enable places in master (no haida flag)

Works well thanks, happy to land once the dependency does
Attachment #8460161 - Flags: review?(dale) → review+
Comment on attachment 8460161 [details] [review]
Pull request - enable places in master (no haida flag)

Will go with Dale's review for now. Vivien - feel free to leave any comments.
Attachment #8460161 - Flags: review?(21)
Enabled in master: https://github.com/mozilla-b2g/gaia/commit/b9240ad3dbb861c2e98150573ce6e4a64b300abb

Going to unblock 1041623 and 1042116, and block the parent user story with them.
Status: NEW → RESOLVED
Closed: 5 years ago
No longer depends on: 1041623, 1042116
Resolution: --- → FIXED
Whiteboard: [systemsfe]
hi Kevin, I think this patch introduced a small performance regression to the Calendar app (startup & moz-chrome-dom-loaded), do you think it's possible? see this comment for more info: https://bugzilla.mozilla.org/show_bug.cgi?id=1059349#c3 Thanks!
Flags: needinfo?(kgrandon)
Depends on: 1063789
(In reply to Miller Medeiros [:millermedeiros] from comment #9)
> hi Kevin, I think this patch introduced a small performance regression to
> the Calendar app (startup & moz-chrome-dom-loaded), do you think it's
> possible? see this comment for more info:
> https://bugzilla.mozilla.org/show_bug.cgi?id=1059349#c3 Thanks!

I've filed bug 1063789 to fix places performance.
Flags: needinfo?(kgrandon)
You need to log in before you can comment on or make changes to this bug.