Closed Bug 1041623 Opened 5 years ago Closed 5 years ago

Properly dedupe places results according to spec

Categories

(Firefox OS Graveyard :: Gaia::Search, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S1 (1aug)

People

(Reporter: daleharvey, Assigned: daleharvey)

References

Details

(Whiteboard: [systemsfe][tako])

Attachments

(1 file)

No description provided.
No longer blocks: 963047
The spec for this is @ https://mozilla.app.box.com/s/lbw2wzw3p4jvxs24k4sg/1/2099951272/19056548695/1

Page 17/19

I am not confident the specification is going to be the final implementation, so calling this out as something that needs to be worked on and enabled soon to go through ux audit
Assignee: nobody → dale
Summary: Implement UX specs for how to display history items → Properly dedupe places results according to spec
dessign as I am not working on it this second
Assignee: dale → nobody
No longer blocks: 1041618
Blocks: 948303
Whiteboard: [systemsfe][tako]
Assignee: nobody → dale
Also revived and reused the places search test, for review purposes ignore any changes to app_chrome, they were causing this to fail but will be fixed seperately
Attachment #8464641 - Flags: review?(kgrandon)
Comment on attachment 8464641 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/22308

Looks good, and thanks for taking a look at the test.

I left a comment on github and it looks like we may need to update a title assertion. Thanks!
Attachment #8464641 - Flags: review?(kgrandon) → review+
https://github.com/mozilla-b2g/gaia/commit/f58bb4c40abbebd9ff9b32fb2a39bf3f44340991

Fixed up the assertions, issue was that a titlechange event may not have been sent down to places by the time we search, switched it to just make sure the app exists

Green try run except known intermitteng Gb @ https://tbpl.mozilla.org/?tree=Gaia-Try&rev=f3f49676690b
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S1 (1aug)
You need to log in before you can comment on or make changes to this bug.