Closed Bug 1041654 Opened 7 years ago Closed 7 years ago

EventTooltip hides overflowing content instead of making it scrollable

Categories

(DevTools :: Inspector, defect)

33 Branch
x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 34

People

(Reporter: sjakthol, Assigned: sjakthol)

Details

Attachments

(2 files)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:33.0) Gecko/20100101 Firefox/33.0 (Beta/Release)
Build ID: 20140721094145

Steps to reproduce:

1. Go to https://google.com
2. Open inspector
3. Click on the ev button of <html> element.
4. Click on the handlers at the bottom of the list.


Actual results:

The event handler code overflowed the unscrollable tooltip viewport.


Expected results:

The viewport should have been scrollable and the viewport should have been scrolled to make the event handler content completely visible in the tooltip.
Component: Untriaged → Developer Tools: Inspector
Screenshot of the issue. Notice that only one line of the event handler is shown, the rest is outside visible area.
Here's a patch that does the following:
- make the tooltip overflow:auto
- align header to with tooltip top if header.top < tooltip.top
- align editor bottom with tooltip bottom if editor.bottom > tooltip.bottom
- test case for this functionality

Feedback is welcome.

Try:
https://tbpl.mozilla.org/?tree=Try&rev=fb1b0f545226
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=fb1b0f545226
Assignee: nobody → sjakthol
Status: NEW → ASSIGNED
Attachment #8479735 - Flags: feedback?(mratcliffe)
Comment on attachment 8479735 [details] [diff] [review]
fix-1041654.patch

Review of attachment 8479735 [details] [diff] [review]:
-----------------------------------------------------------------

Nicely done, I am happy to r+ this.
Attachment #8479735 - Flags: feedback?(mratcliffe) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/69ddae74cd0c
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/69ddae74cd0c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 34
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.