Closed Bug 1041670 Opened 5 years ago Closed 5 years ago

configure.in still has a comment implying that --disable-angle is a thing

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla34

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

fix v1: drop the comment
1021 bytes, patch
jgilbert
: review+
Details | Diff | Splinter Review 
Bug 603367 added ANGLE to the tree, with these lines:

> dnl = ANGLE OpenGL->D3D translator for WebGL
> dnl = * only applies to win32
> dnl = * enabled by default (shipping build); requires explicit --disable to disable
[...]
+[  --disable-angle     Disable building of ANGLE for WebGL->D3D translation],

Later on, bug 772457 removed support for --disable-angle, but the dnl comment still exists.

We should drop the comment.
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #8459713 - Flags: review?(jgilbert)
Attachment #8459713 - Flags: review?(jgilbert) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6353c7925b9e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
QA Whiteboard: [qa-]
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.