Clean up API serializers inheritance chain

RESOLVED WONTFIX

Status

Marketplace
Code Quality
P4
normal
RESOLVED WONTFIX
4 years ago
2 years ago

People

(Reporter: mat, Unassigned)

Tracking

Points:
---

Details

(Whiteboard: [marketplace-transition])

(Reporter)

Description

4 years ago
Right now, the inheritance chain for some of our DRF serializers is a bit weird.

mkt.search.serializers.BaseESSerializer inherits from serializers.ModelSerializer, but doesn't do much that requires that. 

mkt.webapps.serializers.RocketbarESAppSerializer is kept pretty barebones, but it would make sense to refactor it a little to benefit from BaseESSerializer (while still keeping it light & fast).

mkt.webapps.serializers.RocketbarESAppSerializerV2 depends on AppSerializer, but I'm not sure why.

Updated

2 years ago
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WONTFIX
Whiteboard: [marketplace-transition]
You need to log in before you can comment on or make changes to this bug.