1041699 - Unable to add an app to the Featured app and accompanying error message is vague

Status: VERIFIED FIXED

(Marketplace Graveyard :: Curation Tools, defect, P5)

Description

[krupa raj[:krupa]]

+++ This bug was initially created as a clone of Bug #1041209 +++

steps to reproduce:
1. Load https://marketplace-dev.allizom.org/curate/create/apps
2. Search for "facebook"
3. Skip one of the required fields and click Save

expected behavior:
Error message when form submission fails is clear and accurate

observed behavior:
The error message upon clicking "submit" says 'This field is required' which doesn't specify what field is missing

Comment 1

[Davor Spasovski [:spasovski]]

Seems clear enough since it mentions the field name. A better version would be to have the error messages next to the field but I don't see it as such a priority.

Comment 2

[Kevin Ngo [:ngoke]]

Was fixed somewhere. The problem was we weren't catching something on the frontend, so the backend returned the error which we didn't handle well. Now we're catching it on the frontend.

Comment 3

[Kevin Ngo [:ngoke]]

Oh, it was when the feed app type selectors were changed. Chuck fixed.

Comment 4

[krupa raj[:krupa]]

verified at https://marketplace-dev.allizom.org/curate/create/apps