104173 - Get rid of nsIAppShellComponent use in AccessProxy

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect, P1)

Description

[Aaron Leventhal]

AccessProxy is the last thing to use nsIAppShellComponent.

Fix it to use nsIAppStartupNotifier

Comment 1

[Aaron Leventhal]

Attachment: Tested - works well

Comment 2

[Alec Flett]

excellent! the only thing is, that comment about APPSTARTUP_CATEGORY seems
unnecessary in your code... can you just remove that comment and then file a bug
against [e-mail]? I always had trouble with #define'd wide strings, I
didn't know that it dependent on the order included!

cc'ing chak so he can take a look at the comment.

sr=alecf with the removal of the comment and filing of the bug

Comment 3

[Aaron Leventhal]

bug 104221 filed, extraneous comments removed

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 53056 [details] [diff] [review]
Tested - works well

r=dveditz

This is win and unix only? I was going to have you get a Mac build-buddy to make sure the accesspaths included the added headers but I don't see a Mac project.

Comment 5

[Alec Flett]

Comment on attachment 53056 [details] [diff] [review]
Tested - works well

the mac compiler doesn't do REQUIRES - it automatically searches subdirectories for the required header..

Comment 6

[Daniel Veditz [:dveditz]]

Does it search now? Or maybe some projects are set up differently -- I know I've
been bitten in the past by #including a header file from a directory that wasn't
set in the access paths, and the access paths couldn't be changed using camelot.

Comment 7

[Aaron Leventhal]

Mac built fine.

The problem was linux

Where windows needs REQUIRES = appstartup, Linux needs REQUIRES = embedcomponents

Why are they different?

Comment 8

[Daniel Veditz [:dveditz]]

At the mechanical level they're different because the makefiles have a different
MODULE= name in them. Since MODULE= wasn't used for much on windows prior to
this there is a good possibility that they're out of whack all over the tree.

In this case it looks like chak set one and alecf set the windows one.

Comment 9

[Alec Flett]

the only reason they're different is we haven't "aligned" that module yet.. I've
added it to my list in bug 101761
Thanks.. you wanna mark this fixed?

Comment 10

[Aaron Leventhal]

-> oops, thought I had marked this fixed.