Make Details username should link to profile page

RESOLVED FIXED

Status

Webmaker
webmaker.org
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: cade, Assigned: akshaytiwari.003, Mentored)

Tracking

Details

(Whiteboard: [goodfirstbug] )

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 years ago
Username links in the make details page currently link to '/u/{username}' which is shorthand for a make search by that user's username. It should now link to the user's profile.

There's two ways we can resolve this issue:

1. redirect /u/{username} to /user/{username}
2. update the make-details page to link "@username" to /user/{username}

The upside of a redirect it it give a handy shortcut to /user/{username} - but also at the same time, /u/{username} is also handy for doing a search for a user's makes...

My vote, based on the above, is to update the link in make details

Comment 1

4 years ago
 Where should I fork it from? Could you give me the link? I want to try fixing the bug.
Flags: needinfo?(cade)
(Reporter)

Comment 2

4 years ago
(In reply to 14.jeevan from comment #1)
>  Where should I fork it from? Could you give me the link? I want to try
> fixing the bug.

fork from https://github.com/mozilla/webmaker.org
Flags: needinfo?(cade)
(Reporter)

Updated

4 years ago
Mentor: cade@mozillafoundation.org
(Assignee)

Updated

3 years ago
Assignee: nobody → akshaytiwari.003
(Assignee)

Comment 3

3 years ago
Hi cade, help me with the file location , will you?

Updated

3 years ago
Flags: needinfo?(cade)
(Reporter)

Comment 4

3 years ago
(In reply to akshaytiwari.003 from comment #3)
> Hi cade, help me with the file location , will you?

Look here:

https://github.com/mozilla/webmaker.org/blob/5c29d2807666b13209400dd45bc512b644b781c4/views/details.html
Flags: needinfo?(cade)
(Assignee)

Comment 5

3 years ago
Created attachment 8479994 [details] [review]
Make Details username should link to profile page.

Updated

3 years ago
Attachment #8479994 - Flags: review?(cade)
(Reporter)

Comment 6

3 years ago
Comment on attachment 8479994 [details] [review]
Make Details username should link to profile page.

I left a comment in the Github Pull Request for you to look at. Put the review back on me when you make the change.
Attachment #8479994 - Flags: review?(cade) → review-

Comment 7

3 years ago
Created attachment 8500312 [details] [review]
https://github.com/mozilla/webmaker.org/pull/996

Since this was pending from 10 days, decided to submit the patch!
Attachment #8500312 - Flags: review?(cade)
(Assignee)

Comment 9

3 years ago
Status should be changed to resolved.
(Reporter)

Comment 10

3 years ago
good call!
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Reporter)

Updated

3 years ago
Attachment #8500312 - Attachment is obsolete: true
Attachment #8500312 - Flags: review?(cade)
(Reporter)

Updated

3 years ago
Attachment #8479994 - Flags: review- → review+
You need to log in before you can comment on or make changes to this bug.