1041732 - Make Details username should link to profile page

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Chris DeCairos (:cade)]

Username links in the make details page currently link to '/u/{username}' which is shorthand for a make search by that user's username. It should now link to the user's profile.

There's two ways we can resolve this issue:

1. redirect /u/{username} to /user/{username}
2. update the make-details page to link "@username" to /user/{username}

The upside of a redirect it it give a handy shortcut to /user/{username} - but also at the same time, /u/{username} is also handy for doing a search for a user's makes...

My vote, based on the above, is to update the link in make details

Comment 1

[Jeevan M R (:jee1mr)]

 Where should I fork it from? Could you give me the link? I want to try fixing the bug.

Comment 2

[Chris DeCairos (:cade)]

(In reply to 14.jeevan from comment #1)
>  Where should I fork it from? Could you give me the link? I want to try
> fixing the bug.

fork from https://github.com/mozilla/webmaker.org

Comment 3

[akshaytiwari.003]

Hi cade, help me with the file location , will you?

Comment 4

[Chris DeCairos (:cade)]

(In reply to akshaytiwari.003 from comment #3)
> Hi cade, help me with the file location , will you?

Look here:

https://github.com/mozilla/webmaker.org/blob/5c29d2807666b13209400dd45bc512b644b781c4/views/details.html

Comment 5

[akshaytiwari.003]

Attachment: Make Details username should link to profile page.

Comment 6

[Chris DeCairos (:cade)]

Comment on attachment 8479994 [details] [review]
Make Details username should link to profile page.

I left a comment in the Github Pull Request for you to look at. Put the review back on me when you make the change.

Comment 7

[Tanay Pant [:Tanay]]

Attachment: https://github.com/mozilla/webmaker.org/pull/996

Since this was pending from 10 days, decided to submit the patch!

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/0717b8c816d5c94f1de6b8ab402e8885b5e3a7c5
Bug 1041732 - Make Details username should link to profile page

Comment 9

[akshaytiwari.003]

Status should be changed to resolved.

Comment 10

[Chris DeCairos (:cade)]

good call!