1041779 - [Messages][MMS] Download button styles are broken

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Oleg Zasypkin [:azasypkin]]

Attachment: Download button screenshot (current)

Looks like patch from bug 1036147 added new "min-height" and "line-height" for buttons inside lists, so that Download button now looks ugly.

Comment 1

[Oleg Zasypkin [:azasypkin]]

Attachment: Download button screenshot (before)

Comment 2

[Maria Angeles Oteo (:oteo)]

Arnau, can you have a look at it? Thanks a lot!

Comment 3

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: patch in github

Sorry guys, Oleg was right this is a regression caused by bug 1036147.
I tried to review all buttons in gaia, but some of them (like this one) are difficult to catch even with QAwanted :)

Comment 4

[Julien Wajsberg [:julienw]]

Comment on attachment 8460047 [details] [review]
patch in github

Oleg will review :)

Comment 5

[Jason Smith [:jsmith]]

Triage feels this isn't a blocker because there's no apparent user impact to this bug & the visual impact feels minor.

Comment 6

[Julien Wajsberg [:julienw]]

[Blocking Requested - why for this release]:

This is a Visual Refresh bug. I think Visual Refresh is a feature for v2.0, so since it's a bug for a feature it should be a blocker.

If approvals can still be asked I'm fine with doing an approval though.

Comment 7

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8460047 [details] [review]
patch in github

Now it looks good, thanks!

Comment 8

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Merged: 15c84c943e41ad834640a45e1e1c2ac804168af7

Comment 9

[Preeti Raghunath(:Preeti)]

Julien

Please take the approval route here.

Comment 10

[Julien Wajsberg [:julienw]]

Oleg, I'll leave you request an approval for v2.0 here :)

Comment 11

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8460047 [details] [review]
patch in github

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment] Requesting uplift to 2.0 as it is a part of Visual Refresh that is v2.0 feature.
[Bug caused by] (feature/regressing bug #): Bug 1036147
[User impact] if declined: User will see misaligned "Download" button for MMS that wasn't downloaded automatically
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Low, targeted small SMS specific CSS only change
[String changes made]: N/A

Comment 12

[bhavana bajaj [:bajaj]]

Comment on attachment 8460047 [details] [review]
patch in github

Was really on the fence for this one, as this is not a blocker but given the super low risk and manageable risk and keeping in mind the visual refresh work for 2.0 approving this.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/49ff85e95e05e0ddc410bcfd15a70495fc959c12

Comment 14

[Julien Wajsberg [:julienw]]

(In reply to bhavana bajaj [:bajaj] from comment #12)
> Comment on attachment 8460047 [details] [review]
> patch in github
> 
> Was really on the fence for this one, as this is not a blocker but given the
> super low risk and manageable risk and keeping in mind the visual refresh
> work for 2.0 approving this.

Thanks :)

Comment 15

[Paladin]

This issue has been verified successfully on Flame 2.0,2.1

See attachment: Verify_image.png
Reproducing rate: 0/5
Flame 2.0 versions:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/29222e215db8
Build-ID        20141203000201
Version         32.0
Flame 2.1 versions:
Gaia-Rev        dbaf3e31c9ba9c3436e074381744f2971e15c7bf
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/ebce587d2194
Build-ID        20141203001205
Version         34.0

Comment 16

[Paladin]

Attachment: Verify_image.png