Closed Bug 1041795 Opened 5 years ago Closed 5 years ago

--enable-dtrace build fails without kernel module loaded

Categories

(Core :: JavaScript Engine, defect)

All
FreeBSD
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: jbeich, Assigned: jbeich)

Details

Attachments

(1 file, 1 obsolete file)

On FreeBSD using -G for non-root user without dtrace kernel module loaded leads to an error. Loading a module requires root and may not work inside jail with old release. Given that js/src/devtools/javascript-trace.d doesn't use |#pragma D depends_on| let's disable libs.

$ dtrace -G -C -s /dev/null
dtrace: failed to compile script /dev/null: "/usr/lib/dtrace/errno.d", line 30: failed to resolve INP_IPV4: Unknown variable name
zsh: exit 1

$ echo '#pragma D option nolibs' | dtrace -G -C -s /dev/stdin
dtrace: failed to compile script /dev/stdin: "/usr/lib/dtrace/errno.d", line 30: failed to resolve INP_IPV4: Unknown variable name
zsh: exit 1
Component: Build Config → JavaScript Engine
Attached patch add -x nolibs (obsolete) — Splinter Review
-h is affected as well. javascript-trace.h doesn't change here. Alas, only OS X can test --enable-dtrace on TBPL.

https://tbpl.mozilla.org/?tree=Try&rev=edb7cd819cf8
Attachment #8459895 - Flags: feedback?(sphink)
Attachment #8459895 - Flags: feedback?(ginn.chen)
Comment on attachment 8459895 [details] [diff] [review]
add -x nolibs

Review of attachment 8459895 [details] [diff] [review]:
-----------------------------------------------------------------

systemtap's dtrace command on linux seems fine with the -x nolibs option even though I think it ignores it, so it's fine with me if it helps something.
Attachment #8459895 - Flags: feedback?(sphink) → feedback+
Comment on attachment 8459895 [details] [diff] [review]
add -x nolibs

Review of attachment 8459895 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the late.
Attachment #8459895 - Flags: feedback?(ginn.chen) → feedback+
Rebased after bug 1036894, bug 1090107, etc.

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=1fe3443b5627
Attachment #8459895 - Attachment is obsolete: true
Attachment #8516589 - Flags: review?(mh+mozilla)
Attachment #8516589 - Flags: review?(mh+mozilla) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9a5b654fadb9
Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.