Closed Bug 1041830 Opened 5 years ago Closed 5 years ago

Backout bug 1030206

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34
Tracking Status
firefox33 --- fixed
firefox34 --- fixed

People

(Reporter: wlitwinczyk, Assigned: wlitwinczyk)

References

Details

Attachments

(2 files)

Backing out bug 1030206 until it can be implemented with a better workaround.
Made with hg diff -c 194567 --reverse
Attachment #8459911 - Flags: review?(dglastonbury)
Made with hg diff -c 194568 --reverse
Attachment #8459912 - Flags: review?(dglastonbury)
Attachment #8459911 - Flags: review?(dglastonbury) → review+
Attachment #8459912 - Flags: review?(dglastonbury) → review+
https://hg.mozilla.org/mozilla-central/rev/88509c58e0d8
https://hg.mozilla.org/mozilla-central/rev/d0413e0afd6a
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Depends on: 1030206
Comment on attachment 8459911 [details] [diff] [review]
bug_1030206_backout_patch1

Approval Request Comment (For Firefox v33)
[Feature/regressing bug #]:
  Bug 1041830

[User impact if declined]:
  Various online demos will be broken, including an upcoming demo from EPIC
  https://bugzilla.mozilla.org/show_bug.cgi?id=1030206#c24
  http://jonathan-olson.com/tesserace/tests/3d.html

[Describe test coverage new/current, TBPL]:
  Try: https://bugzilla.mozilla.org/show_bug.cgi?id=1041830#c3

[Risks and why]: 
  Requested by Sylvestre Ledru:
  https://bugzilla.mozilla.org/show_bug.cgi?id=1041301#c7

  and it's a breaking change because on windows ANGLE doesn't 
  fully support the needed extension, so it won't work at all:
  
  https://bugzilla.mozilla.org/show_bug.cgi?id=1030206#c37
[String/UUID change made/needed]:
  None
Attachment #8459911 - Flags: approval-mozilla-aurora?
Comment on attachment 8459912 [details] [diff] [review]
bug_1030206_backout_patch2

See above request
Attachment #8459912 - Flags: approval-mozilla-aurora?
(In reply to Walter Litwinczyk [:walter] from comment #6)
> 
> [Risks and why]: 
>   Requested by Sylvestre Ledru:
>   https://bugzilla.mozilla.org/show_bug.cgi?id=1041301#c7
> 
>   and it's a breaking change because on windows ANGLE doesn't 
>   fully support the needed extension, so it won't work at all:
>   
>   https://bugzilla.mozilla.org/show_bug.cgi?id=1030206#c37

Could you elaborate on this? What means "breaking change"? What is the impact to user if we revert in 33 too?
Thanks
Flags: needinfo?(wlitwinczyk)
Well it's 'breaking' in that the functionality of rendering to a floating point texture worked implicitly before and with the change it requires a preference to be enabled. This was unacceptable to some vendors. Additionally, even after enabling the pref it does not work on some platforms due to a limitation in our backend, whereas it worked without the change. Backing this out reverts Firefox to the old behavior that was being relied on in many applications.

A more elaborate explanation can be found here:
https://bugzilla.mozilla.org/show_bug.cgi?id=1030206#c24
Flags: needinfo?(wlitwinczyk)
Comment on attachment 8459912 [details] [diff] [review]
bug_1030206_backout_patch2

OK. If we come back to the 31 situation, I am happy with that!
Thanks
Attachment #8459912 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8459911 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/68538e095002

Pushed as one folded patch because the commit messages were basically the same anyway.
You need to log in before you can comment on or make changes to this bug.