Closed Bug 1041833 Opened 5 years ago Closed 4 years ago

Enable CSSOM-View smooth scrolling for Android

Categories

(Firefox for Android :: Toolbar, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 46
Tracking Status
firefox46 --- fixed

People

(Reporter: kip, Assigned: rbarker)

References

()

Details

Attachments

(1 file)

Before CSSOM-View Scroll-Behavior can be enabled for Firefox for Android, JavaPanZoomController (and possibly others) must be updated.

- Scroll events must cancel CSSOM-View smooth scroll animations
- Fling gestures must not cancel CSSOM-View smooth scroll animations that are started during the deceleration; the CSSOM-View smooth scroll position updates must preempt the fling gesture deceleration position updates.

See the patch set of Bug 1022825 for examples of how this may be integrated.
Assignee: nobody → kgilbert
I think it would probably be better to just switch Fennec over to using the C++ APZC code than to have yet another binding for the smooth scrolling code. Bug 776030 is tracking that work, and I think we're actually in pretty good shape to be able to implement that soon.
Yes please (to bug 776030) - we have to reduce the number of code paths we take.
Depends on: apz-fennec
See Also: → 1087559
Depends on: 1087562
Depends on: 1087559
Once Bug 776030 lands, CSSOM-View scroll-behavior smooth scrolling should be tested on Fennec.  Once its confirmed working, then the preferences to enable the CSSOM-View scroll-behavior property and DOM method extensions should be enabled for Fennec by default:

layout.css.scroll-behavior.enabled
layout.css.scroll-behavior.property-enabled
Summary: Implement CSSOM-View smooth scrolling for Android → Enable CSSOM-View smooth scrolling for Android
Now that we have APZ enabled on nightly we should turn this on as well and make sure it works well.
No longer depends on: apz-fennec
Test page : https://staktrace.com/resources/extras/spout/scroll-behavior.html

Without smooth scrolling it jumps to the bottom with smooth scrolling it should scroll down in an animation
Comment on attachment 8697585 [details] [diff] [review]
0001-Bug-1041833-Enable-CSSOM-View-smooth-scrolling-for-Android-15121111-b9634be.patch

Review of attachment 8697585 [details] [diff] [review]:
-----------------------------------------------------------------

I think the prefs should be true on every other platform already so you should be able to just make it true unconditionally and remove it from any platform-specific pref files.
Actually ignore comment 7. It's not enabled on b2g. So land your stuff and I can file another bug to clean it up and enable it on b2g (which I assume is an oversight).
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #8)
> Actually ignore comment 7. It's not enabled on b2g. So land your stuff and I
> can file another bug to clean it up and enable it on b2g (which I assume is
> an oversight).

What about Fennec with JPZ? I assume that should also remain disabled?
Assignee: kgilbert → rbarker
Attachment #8697585 - Flags: review?(snorp)
Yeah it should remain disabled with JPZ.
Attachment #8697585 - Flags: review?(snorp) → review+
https://hg.mozilla.org/mozilla-central/rev/4d337f2abcaf
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
You need to log in before you can comment on or make changes to this bug.