Clean up the H.264/AAC whitelisting code in HTML media

RESOLVED WORKSFORME

Status

()

RESOLVED WORKSFORME
4 years ago
a year ago

People

(Reporter: cajbir, Assigned: jya)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

4 years ago
The detection and whitelisting of H.264/AAC codecs is spread across numerous places in the media code. There is, and not limited too, the following places where codecs are repeated:

content/media/gstreamer/GStreamerFormatHelper.cpp
content/media/DecoderTraits.cpp
content/media/fmp4/MP4Decoder.cpp
media/omx-plugin/OmxPlugin.cpp

Much of this code repeats strings and needs to be updated in multiple places. 

There is also code in content/media/mediasource/MediaSource.cpp that defines the codecs allowed in MSE (in gMediaSourceTypes).

This code should be refactored to make sure that there is a single place to be edited for adding supported codecs and formats and for whitelisting or preventing codecs from being used. 

Backends that support multiple formats should use the platform facilities to confirm existence of support for the requested format.
Assignee: nobody → jyavenard
Also see http://src.chromium.org/viewvc/chrome?revision=277386&view=revision for changes made to Blink recently that has caused some fallout.
Component: Audio/Video → Audio/Video: Playback
(Assignee)

Updated

2 years ago
See Also: → bug 1176218
(Assignee)

Comment 2

a year ago
this was done with the MediaMimeType object
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.