Closed Bug 1041880 Opened 5 years ago Closed 5 years ago

Use GetParentElementCrossingShadow() when initializing style scopes

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: wchen, Assigned: wchen)

Details

Attachments

(2 files)

Attached file Assertion stack
While debugging a test case in bug 1022866, I run into an assertion in TreeMatchContext::AssertHasAllStyleScopes, where mStyleScopes is missing a shadow root-crossing ancestor of a node in a shadow tree.

In TreeMatchContext::InitStyleScopes, we cross the shadow root boundary when traversing the parent chain, but in InitStyleScopes in nsStyleSet.cpp, we do not cross the boundary when obtaining the parent element.
Attachment #8459994 - Flags: review?(cam) → review+
https://hg.mozilla.org/mozilla-central/rev/16ab083beab4
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
QA Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.