Closed
Bug 1041893
Opened 10 years ago
Closed 10 years ago
GetBackgroundClip doesn't need to record the clip rect direction
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: mattwoodrow, Assigned: mattwoodrow)
References
Details
Attachments
(1 file)
|
3.90 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
By the looks of things this code was copied from border painting code and was never actually required. Border painting clips to two rects at the same time (inner/outer edges of the border), and so needs the inner rectangle to be clockwise so that the clipped region is the enclosed border area. For background clipping we only have a single rect, so recording the direction has no effect and makes the code more confusing than necessary.
Attachment #8460032 -
Flags: review?(roc)
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → matt.woodrow
Attachment #8460032 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 1•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f63b1f47aa8f
|
||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f63b1f47aa8f
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•