1041910 - [Music] Customize Status Bar Color

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Michael Henretty [:mikehenrty][:mhenretty]]

For 2.1, each app will have a customized status bar color. Work to support this was completed in bug 1013913 and bug 1033364. Now we must update each of the apps with the appropriate meta tags as specified in the visual spec:

https://bug1041625.bugzilla.mozilla.org/attachment.cgi?id=8460033

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: [Gaia PR] add theme color for music

Adding theme color for media app according to: https://bug1041625.bugzilla.mozilla.org/attachment.cgi?id=8470321

Comment 2

[Dominic Kuo [:dkuo]]

Hi Michael, before r+ing this simple patch, just want to clarify that, do we have to also apply the theme when some app is launched as web activity? if so, then we should add the theme meta to the other html(open.html) so that the theme will be applied when music is in activity mode, thanks!

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

That's a good question. Eric, do we need to apply statusbar changes for web activities?

Comment 4

[Eric Pang [:epang] UX]

(In reply to Michael Henretty [:mhenretty] from comment #3)
> That's a good question. Eric, do we need to apply statusbar changes for web
> activities?

Hi, how are web activities launched in media apps?  Do they go into the browser?  If that's the case the status bar should match the browser specs. But if they stay in the media app then they should follow the media spec.  Let me know if I'm not making sesne :)

Comment 5

[Dominic Kuo [:dkuo]]

(In reply to Eric Pang [:epang] from comment #4)
> (In reply to Michael Henretty [:mhenretty] from comment #3)
> > That's a good question. Eric, do we need to apply statusbar changes for web
> > activities?
> 
> Hi, how are web activities launched in media apps?  Do they go into the
> browser?  If that's the case the status bar should match the browser specs.
> But if they stay in the media app then they should follow the media spec. 
> Let me know if I'm not making sesne :)

For media apps like gallery, video and music, besides the regular mode they also have activity mode to support OPEN or PICK some files, so the cases are like we add some attachments in email/sms, it will launch the media pickers, or to view some attachments with the media viewers, those are the web activities for the media apps.

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Dominic Kuo [:dkuo] from comment #5)
> (In reply to Eric Pang [:epang] from comment #4)
> > (In reply to Michael Henretty [:mhenretty] from comment #3)
> > > That's a good question. Eric, do we need to apply statusbar changes for web
> > > activities?
> > 
> > Hi, how are web activities launched in media apps?  Do they go into the
> > browser?  If that's the case the status bar should match the browser specs.
> > But if they stay in the media app then they should follow the media spec. 
> > Let me know if I'm not making sesne :)
> 
> For media apps like gallery, video and music, besides the regular mode they
> also have activity mode to support OPEN or PICK some files, so the cases are
> like we add some attachments in email/sms, it will launch the media pickers,
> or to view some attachments with the media viewers, those are the web
> activities for the media apps.

Yup, we will need to update the activity entry points as well. Good catch Dominic!

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8471251 [details] [review]
[Gaia PR] add theme color for music

I'll remove review flag until we get this fixed.

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8471251 [details] [review]
[Gaia PR] add theme color for music

Good catch again Dominic. I updated the PR with both entry points and made it adhere to the latest spec, which is here:

https://bug1041625.bugzilla.mozilla.org/attachment.cgi?id=8476849

Comment 9

[Dominic Kuo [:dkuo]]

Comment on attachment 8471251 [details] [review]
[Gaia PR] add theme color for music

The patch looks good to me and thanks for working on this, Michael!

Comment 10

[Michael Henretty [:mikehenrty][:mhenretty]]

master: https://github.com/mozilla-b2g/gaia/commit/803d9142ee42dc4640e47ad0644996e4e2493505

Comment 11

[Elie]

Attachment: Music screenshot.png

This issue has been successfully verified on Flame 2.1:
Gaia-Rev        5372b675e018b6aac97d95ff5db8d4bd16addb9b
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/f34377ae402b
Build-ID        20141127001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2