[Settings] Customize Status Bar Color

RESOLVED FIXED in Firefox OS v2.1

Status

Firefox OS
Gaia::Settings
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mikehenrty, Assigned: mikehenrty)

Tracking

unspecified
2.1 S3 (29aug)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(b2g-v2.1 fixed)

Details

(Whiteboard: [systemsfe])

Attachments

(2 attachments)

For 2.1, each app will have a customized status bar color. Work to support this was completed in bug 1013913 and bug 1033364. Now we must update each of the apps with the appropriate meta tags as specified in the visual spec:

https://bug1041625.bugzilla.mozilla.org/attachment.cgi?id=8460033
Depends on: 1041916
Target Milestone: 2.1 S1 (1aug) → 2.1 S2 (15aug)
We have a work around in place that does not make us rely on icon fonts.
No longer depends on: 1041916
Created attachment 8471253 [details] [review]
[Gaia PR] fix theme color for settings

Fix settings theme color according to spec: https://bug1041625.bugzilla.mozilla.org/attachment.cgi?id=8470321
Attachment #8471253 - Flags: review?(ehung)
Created attachment 8471254 [details]
[screenshot] Settings with theme color
Attachment #8471254 - Flags: ui-review?(epang)
Comment on attachment 8471254 [details]
[screenshot] Settings with theme color

Hi Michel, this patch takes into account the status bar colour and icons right?
R+ for these. 

The Rocket bar isn't to spec (font styling/size) and input field, but this isn't part of this bug is it?  If so please let me know.
Attachment #8471254 - Flags: ui-review?(epang) → ui-review+
Flags: needinfo?(mhenretty)
Correct, the rocketbar styling is not part of this bug. Please file a bug about that.
Flags: needinfo?(mhenretty)

Comment 6

4 years ago
Comment on attachment 8471253 [details] [review]
[Gaia PR] fix theme color for settings

thanks!
Attachment #8471253 - Flags: review?(ehung) → review+
master: https://github.com/mozilla-b2g/gaia/commit/8a3df6213b5b86d3d32ead74618d53c62f790e54
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-b2g-v2.1: --- → fixed
Resolution: --- → FIXED
Target Milestone: 2.1 S2 (15aug) → 2.1 S3 (29aug)
You need to log in before you can comment on or make changes to this bug.