Closed
Bug 1041911
Opened 10 years ago
Closed 10 years ago
[Settings] Customize Status Bar Color
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(b2g-v2.1 fixed)
RESOLVED
FIXED
2.1 S3 (29aug)
| Tracking | Status | |
|---|---|---|
| b2g-v2.1 | --- | fixed |
People
(Reporter: mikehenrty, Assigned: mikehenrty)
References
Details
(Whiteboard: [systemsfe])
Attachments
(2 files)
|
46 bytes,
text/x-github-pull-request
|
jj.evelyn
:
review+
|
Details | Review |
|
44.69 KB,
image/png
|
epang
:
ui-review+
|
Details |
[screenshot] Settings with theme color
For 2.1, each app will have a customized status bar color. Work to support this was completed in bug 1013913 and bug 1033364. Now we must update each of the apps with the appropriate meta tags as specified in the visual spec: https://bug1041625.bugzilla.mozilla.org/attachment.cgi?id=8460033
|
||
Updated•10 years ago
|
Target Milestone: 2.1 S1 (1aug) → 2.1 S2 (15aug)
|
Assignee | |
Comment 1•10 years ago
|
||
We have a work around in place that does not make us rely on icon fonts.
No longer depends on: 1041916
|
|
Assignee | |
Comment 2•10 years ago
|
||
Fix settings theme color according to spec: https://bug1041625.bugzilla.mozilla.org/attachment.cgi?id=8470321
Attachment #8471253 -
Flags: review?(ehung)
|
|
Assignee | |
Comment 3•10 years ago
|
||
Attachment #8471254 -
Flags: ui-review?(epang)
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8471254 [details]
[screenshot] Settings with theme color
Hi Michel, this patch takes into account the status bar colour and icons right?
R+ for these.
The Rocket bar isn't to spec (font styling/size) and input field, but this isn't part of this bug is it? If so please let me know.
Attachment #8471254 -
Flags: ui-review?(epang) → ui-review+
Flags: needinfo?(mhenretty)
|
|
Assignee | |
Comment 5•10 years ago
|
||
Correct, the rocketbar styling is not part of this bug. Please file a bug about that.
Flags: needinfo?(mhenretty)
|
||
Comment 6•10 years ago
|
||
Comment on attachment 8471253 [details] [review] [Gaia PR] fix theme color for settings thanks!
Attachment #8471253 -
Flags: review?(ehung) → review+
|
|
Assignee | |
Comment 7•10 years ago
|
||
master: https://github.com/mozilla-b2g/gaia/commit/8a3df6213b5b86d3d32ead74618d53c62f790e54
Status: NEW → RESOLVED
Closed: 10 years ago
status-b2g-v2.1:
--- → fixed
Resolution: --- → FIXED
Target Milestone: 2.1 S2 (15aug) → 2.1 S3 (29aug)
You need to log in
before you can comment on or make changes to this bug.
Description
•