1041945 - Lockscreen notifications timestamps have wrong visual style

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[John Lu [:mnjul][Please NI or I'll miss]]

Attachment: 2014-07-22-08-10-56.png

Lockscreen notifications timestamps are having wrong visual styles (blue & non-italic text, wrong vertical & horizontal position), see attachment.

Comment 1

[John Lu [:mnjul][Please NI or I'll miss]]

This bug is probably because we didn't merge changes made by bug 1035430 (such as https://github.com/mozilla-b2g/gaia/commit/0754b52c7d279203c031b3ec61c778b2bdc61283#diff-34ac4f93978f5ace27b51ad2f2229c91R255 ) when we landed bug 1023500 (which removed lockscreen notification CSS from notifications.css to lockscreen.css). Should be quickly fixable by incorporating the CSS changes.

Comment 2

[John Lu [:mnjul][Please NI or I'll miss]]

Attachment: Patch (PR @ GitHub)

Here is my CSS patch. Greg, could you review? I hope we will get fewer and fewer of these after we get lockscreen as an app......

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8460096 [details] [review]
Patch (PR @ GitHub)

Review+ because the notifications now is correct.

Comment 4

[John Lu [:mnjul][Please NI or I'll miss]]

Waiting for TBPL to land onto master. We probably will need to seek uplift for this onto 2.0 since bug 1035430 is in 2.0.

Comment 5

[John Lu [:mnjul][Please NI or I'll miss]]

TBPL has been continuously failing with some Gij test that also fails with other PRs before mine. So proceeding to merge anyway.

Comment 6

[John Lu [:mnjul][Please NI or I'll miss]]

Master: https://github.com/mozilla-b2g/gaia/commit/e391c55470d1537e0fdec48cf71e4f3a5cb0eec8