1041969 - Disabled icons in context menu are invisible if hovered in High Contrast White theme

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Cornel Ionce [:noni] [Hubs QA]]

Attachment: hover_inactive_icons_in_context_menu.jpg

Steps to reproduce:
1. Right click on desktop and click personalize.
2. Scroll down and select the High Contrast White theme.
3. Open Firefox
4. Right click on an empty area of the page
5. Hover over the inactive buttons (eg. next / previous)

Expected results:
The icons are properly displayed when hovered.

Actual results:
The inactive icons are not displayed while hover. A black square displayed instead.


This issue seems to be caused by bug 1016405. Before this, the icons were barely visible, but they could be seen.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Sounds like we should track this for 32 as well?

Comment 2

[Dão Gottwald [:dao]]

(In reply to :Gavin Sharp [email: [e-mail]] from comment #1)
> Sounds like we should track this for 32 as well?

See bug 1041121 comment 4

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch

Still need to test this on Windows.

This should also fix bug 1041121.

Comment 4

[Marco Mucci [:MarcoM]]

Added to Iteration 34.1

Comment 6

[Mike de Boer [:mikedeboer]]

Comment on attachment 8460934 [details] [diff] [review]
patch

Review of attachment 8460934 [details] [diff] [review]:
-----------------------------------------------------------------

The code was looking a-ok days ago, but the testing bit took the most of my time.

I'd say: ship it! This is a great improvement and a good showcase of mad SVG skillz.

Comment 7

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/fx-team/rev/92bfe30723a6

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/92bfe30723a6

Comment 9

[Marco Mucci [:MarcoM]]

Hi Florin, following up to see if this bug can be verified by the end of the iteration on Monday August 4.

Comment 10

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

I reproduced the initial issue with Firefox 34 Nightly from July 22nd.

I then tried the latest Firefox 34 Nightly: User Agent - Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:34.0) Gecko/20100101 Firefox/34.0; BuildID - 20140730030201. With it now I get green Forward/Back buttons in the context menu (they remain green when hovered). See the attached screenshot. The icons are gray when using a normal theme, as expected. 

Is this the intended fix?

Comment 11

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Attachment: Context Menu green icons.png

Comment 12

[Dão Gottwald [:dao]]

(In reply to Florin Mezei, QA (:FlorinMezei) from comment #10)
> I reproduced the initial issue with Firefox 34 Nightly from July 22nd.
> 
> I then tried the latest Firefox 34 Nightly: User Agent - Mozilla/5.0
> (Windows NT 6.1; Win64; x64; rv:34.0) Gecko/20100101 Firefox/34.0; BuildID -
> 20140730030201. With it now I get green Forward/Back buttons in the context
> menu (they remain green when hovered). See the attached screenshot. The
> icons are gray when using a normal theme, as expected. 
> 
> Is this the intended fix?

yes

Comment 13

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Thanks Dão! Marking as verified.

Comment 14

[Tim Nguyen :ntim]

Shouldn't we wait for aurora and beta uplift before verification ?

Comment 15

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

(In reply to Tim Nguyen [:ntim] from comment #14)
> Shouldn't we wait for aurora and beta uplift before verification ?

I don't see why. When uplifted, just set "[qa+]" again in the QA Whiteboard and QA verification will follow.

Comment 16

[Dão Gottwald [:dao]]

Comment on attachment 8460934 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: bug 1016405
[User impact if declined]: minor accessibility problem with high-contrast OS themes
[Describe test coverage new/current, TBPL]: theme code only, no test coverage
[Risks and why]: straightforward theme changes, low risk
[String/UUID change made/needed]: none

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/de3ce0faf034
https://hg.mozilla.org/releases/mozilla-beta/rev/011c4355f782

Comment 18

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Verified as fixed on Firefox 32 Beta 3 on Win 7 x64 - BuildID: 20140731191115 - User Agent: 	Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0.

The green Back/Forward icons display for the High Contrast White theme.

Comment 19

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Verified as fixed on the latest Firefox 33 Aurora on Win 7 x64 - BuildID: 20140731004002 - User Agent: 	Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0.

The green Back/Forward icons display for the High Contrast White theme.