Closed Bug 1041969 Opened 5 years ago Closed 5 years ago

Disabled icons in context menu are invisible if hovered in High Contrast White theme

Categories

(Firefox :: Theme, defect)

x86_64
Windows 7
defect
Not set
Points:
3

Tracking

()

VERIFIED FIXED
Firefox 34
Iteration:
34.1
Tracking Status
firefox32 + verified
firefox33 --- verified
firefox34 --- verified

People

(Reporter: cornel_ionce, Assigned: dao)

References

Details

Attachments

(3 files)

Steps to reproduce:
1. Right click on desktop and click personalize.
2. Scroll down and select the High Contrast White theme.
3. Open Firefox
4. Right click on an empty area of the page
5. Hover over the inactive buttons (eg. next / previous)

Expected results:
The icons are properly displayed when hovered.

Actual results:
The inactive icons are not displayed while hover. A black square displayed instead.


This issue seems to be caused by bug 1016405. Before this, the icons were barely visible, but they could be seen.
Flags: firefox-backlog+
Sounds like we should track this for 32 as well?
Flags: needinfo?(dao)
(In reply to :Gavin Sharp [email: gavin@gavinsharp.com] from comment #1)
> Sounds like we should track this for 32 as well?

See bug 1041121 comment 4
Component: Menus → Theme
Flags: needinfo?(dao)
Points: --- → 3
QA Whiteboard: [qa+]
Version: 33 Branch → Trunk
Attached patch patchSplinter Review
Still need to test this on Windows.

This should also fix bug 1041121.
Assignee: nobody → dao
Status: NEW → ASSIGNED
Blocks: 1041121
Summary: Inactive icons in context menu are not visible if hovered in High Contrast White theme → Disabled icons in context menu are invisible if hovered in High Contrast White theme
Added to Iteration 34.1
Iteration: --- → 34.1
Attachment #8460934 - Flags: review?(mdeboer)
Duplicate of this bug: 1041121
QA Contact: florin.mezei
Comment on attachment 8460934 [details] [diff] [review]
patch

Review of attachment 8460934 [details] [diff] [review]:
-----------------------------------------------------------------

The code was looking a-ok days ago, but the testing bit took the most of my time.

I'd say: ship it! This is a great improvement and a good showcase of mad SVG skillz.
Attachment #8460934 - Flags: review?(mdeboer) → review+
https://hg.mozilla.org/mozilla-central/rev/92bfe30723a6
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Hi Florin, following up to see if this bug can be verified by the end of the iteration on Monday August 4.
Flags: needinfo?(florin.mezei)
I reproduced the initial issue with Firefox 34 Nightly from July 22nd.

I then tried the latest Firefox 34 Nightly: User Agent - Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:34.0) Gecko/20100101 Firefox/34.0; BuildID - 20140730030201. With it now I get green Forward/Back buttons in the context menu (they remain green when hovered). See the attached screenshot. The icons are gray when using a normal theme, as expected. 

Is this the intended fix?
Flags: needinfo?(florin.mezei) → needinfo?(dao)
(In reply to Florin Mezei, QA (:FlorinMezei) from comment #10)
> I reproduced the initial issue with Firefox 34 Nightly from July 22nd.
> 
> I then tried the latest Firefox 34 Nightly: User Agent - Mozilla/5.0
> (Windows NT 6.1; Win64; x64; rv:34.0) Gecko/20100101 Firefox/34.0; BuildID -
> 20140730030201. With it now I get green Forward/Back buttons in the context
> menu (they remain green when hovered). See the attached screenshot. The
> icons are gray when using a normal theme, as expected. 
> 
> Is this the intended fix?

yes
Flags: needinfo?(dao)
Thanks Dão! Marking as verified.
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa+] → [qa!]
Shouldn't we wait for aurora and beta uplift before verification ?
(In reply to Tim Nguyen [:ntim] from comment #14)
> Shouldn't we wait for aurora and beta uplift before verification ?

I don't see why. When uplifted, just set "[qa+]" again in the QA Whiteboard and QA verification will follow.
Comment on attachment 8460934 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: bug 1016405
[User impact if declined]: minor accessibility problem with high-contrast OS themes
[Describe test coverage new/current, TBPL]: theme code only, no test coverage
[Risks and why]: straightforward theme changes, low risk
[String/UUID change made/needed]: none
Attachment #8460934 - Flags: approval-mozilla-beta?
Attachment #8460934 - Flags: approval-mozilla-aurora?
Attachment #8460934 - Flags: approval-mozilla-beta?
Attachment #8460934 - Flags: approval-mozilla-beta+
Attachment #8460934 - Flags: approval-mozilla-aurora?
Attachment #8460934 - Flags: approval-mozilla-aurora+
QA Whiteboard: [qa!] → [qa+]
Verified as fixed on Firefox 32 Beta 3 on Win 7 x64 - BuildID: 20140731191115 - User Agent: 	Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0.

The green Back/Forward icons display for the High Contrast White theme.
Verified as fixed on the latest Firefox 33 Aurora on Win 7 x64 - BuildID: 20140731004002 - User Agent: 	Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0.

The green Back/Forward icons display for the High Contrast White theme.
QA Whiteboard: [qa+] → [qa!]
You need to log in before you can comment on or make changes to this bug.