1042043 - Clicking on an event bubble results in TypeError: this._tooltip is null

Status: VERIFIED FIXED

(DevTools :: Inspector, defect)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

It's pretty consistent in every site for me, but for the record:

1. Open the inspector in http://htmlpad.org/debugger/
2. Click on the event bubble next to the button element.
3. Click on the pause button in the tooltip.
4. The following appears in the terminal log:

System JS : ERROR resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/shared/widgets/Tooltip.js:1209 - TypeError: this._tooltip is null

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: this-tooltip-is-null-1042043.patch

Simple fix.

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8474567 [details] [diff] [review]
this-tooltip-is-null-1042043.patch

Review of attachment 8474567 [details] [diff] [review]:
-----------------------------------------------------------------

Might be a good idea to add a comment explaining why the tooltip would be null there.

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: this-tooltip-is-null-1042043.patch

(In reply to Panos Astithas [:past] from comment #2)
> Comment on attachment 8474567 [details] [diff] [review]
> this-tooltip-is-null-1042043.patch
> 
> Review of attachment 8474567 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Might be a good idea to add a comment explaining why the tooltip would be
> null there.

I have moved the return inside the conditional as this is tidier and makes it self documenting.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/d5f620f1c76c

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d5f620f1c76c

Comment 6

[Andrei Vaida [:avaida]]

Reproduced on Nightly 34.0a1 (2014-07-22) using Windows 7 64-bit.

Verified fixed on Firefox 34.0b1 (build2: 20141014134955) using Windows 7 64-bit, Ubuntu 14.04 LTS 32-bit and Mac OS X 10.9.5.