Closed
Bug 1042043
Opened 11 years ago
Closed 11 years ago
Clicking on an event bubble results in TypeError: this._tooltip is null
Categories
(DevTools :: Inspector, defect)
Tracking
(firefox34 verified)
VERIFIED
FIXED
Firefox 34
| Tracking | Status | |
|---|---|---|
| firefox34 | --- | verified |
People
(Reporter: past, Assigned: miker)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1006 bytes,
patch
|
miker
:
review+
|
Details | Diff | Splinter Review |
It's pretty consistent in every site for me, but for the record:
1. Open the inspector in http://htmlpad.org/debugger/
2. Click on the event bubble next to the button element.
3. Click on the pause button in the tooltip.
4. The following appears in the terminal log:
System JS : ERROR resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/shared/widgets/Tooltip.js:1209 - TypeError: this._tooltip is null
|
Assignee | |
Comment 1•11 years ago
|
||
Simple fix.
|
Reporter | |
Comment 2•11 years ago
|
||
Comment on attachment 8474567 [details] [diff] [review]
this-tooltip-is-null-1042043.patch
Review of attachment 8474567 [details] [diff] [review]:
-----------------------------------------------------------------
Might be a good idea to add a comment explaining why the tooltip would be null there.
Attachment #8474567 -
Flags: review?(past) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
(In reply to Panos Astithas [:past] from comment #2)
> Comment on attachment 8474567 [details] [diff] [review]
> this-tooltip-is-null-1042043.patch
>
> Review of attachment 8474567 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> Might be a good idea to add a comment explaining why the tooltip would be
> null there.
I have moved the return inside the conditional as this is tidier and makes it self documenting.
Attachment #8474567 -
Attachment is obsolete: true
Attachment #8476653 -
Flags: review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 4•11 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 34
|
||
Updated•11 years ago
|
Flags: qe-verify+
|
||
Comment 6•11 years ago
|
||
Reproduced on Nightly 34.0a1 (2014-07-22) using Windows 7 64-bit.
Verified fixed on Firefox 34.0b1 (build2: 20141014134955) using Windows 7 64-bit, Ubuntu 14.04 LTS 32-bit and Mac OS X 10.9.5.
Status: RESOLVED → VERIFIED
status-firefox34:
--- → verified
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•