Closed Bug 1042043 Opened 9 years ago Closed 9 years ago

Clicking on an event bubble results in TypeError: this._tooltip is null

Categories

(DevTools :: Inspector, defect)

Product:
DevTools
Component:
Inspector
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox34 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 34
Tracking Flags:
Tracking Status
firefox34 --- verified

People

(Reporter: past, Assigned: miker)

References

Details

Attachments

(1 file, 1 obsolete file)

this-tooltip-is-null-1042043.patch
1006 bytes, patch
miker
: review+
Details | Diff | Splinter Review 
It's pretty consistent in every site for me, but for the record:

1. Open the inspector in http://htmlpad.org/debugger/
2. Click on the event bubble next to the button element.
3. Click on the pause button in the tooltip.
4. The following appears in the terminal log:

System JS : ERROR resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/shared/widgets/Tooltip.js:1209 - TypeError: this._tooltip is null
Simple fix.
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
Attachment #8474567 - Flags: review?(past)
Comment on attachment 8474567 [details] [diff] [review]
this-tooltip-is-null-1042043.patch

Review of attachment 8474567 [details] [diff] [review]:
-----------------------------------------------------------------

Might be a good idea to add a comment explaining why the tooltip would be null there.
Attachment #8474567 - Flags: review?(past) → review+
(In reply to Panos Astithas [:past] from comment #2)
> Comment on attachment 8474567 [details] [diff] [review]
> this-tooltip-is-null-1042043.patch
> 
> Review of attachment 8474567 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Might be a good idea to add a comment explaining why the tooltip would be
> null there.

I have moved the return inside the conditional as this is tidier and makes it self documenting.
Attachment #8474567 - Attachment is obsolete: true
Attachment #8476653 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/d5f620f1c76c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 34
Reproduced on Nightly 34.0a1 (2014-07-22) using Windows 7 64-bit.

Verified fixed on Firefox 34.0b1 (build2: 20141014134955) using Windows 7 64-bit, Ubuntu 14.04 LTS 32-bit and Mac OS X 10.9.5.
Status: RESOLVED → VERIFIED
status-firefox34: --- → verified
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.