Closed Bug 1042098 Opened 6 years ago Closed 6 years ago

OdinMonkey: don't take(fp) when mir->instrumentedProfiling()

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: luke, Assigned: luke)

Details

Attachments

(1 file)

asm.js code doesn't get recompiled when profiling is enabled/disabled, so it doesn't make sense to attempt to preserve FramePointer when mir->instrumentedProfiling since this only works if profiling is enabled when the app is initially loaded.  Worse, the profiling mode isn't in the cache key, so a cache hit could serve fp-preserved code when profiling is disabled and vice versa.  For regularity (and to make profiling perf more similar to non-profiling), I'd like to not preserve FP for asm.js ever.  To properly handle JIT code when native unwinding, I think we just need to generalize what was done for EHABI (save register state at JIT entry so native unwinding can resume below the JIT activation).
Attachment #8460272 - Flags: review?(jdemooij)
Attachment #8460272 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/d83c2125ae04
... and I just noticed that I have r=dougc when it should be r=jandem.  Let it be noted.
https://hg.mozilla.org/mozilla-central/rev/d83c2125ae04
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
QA Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.