Closed
Bug 1042115
Opened 10 years ago
Closed 10 years ago
Bug 984711 and/or bug 1037177 required a clobber due to GenerateCSS2PropertiesWebIDL.py syntax error from "Start server"
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1027450
People
(Reporter: emorley, Unassigned)
References
(Blocks 1 open bug)
Details
Sounds similar to what was hit in bug 1019955 and a result of scache.
Something in this push:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?startID=46604&endID=46605
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=b489ff052163
Resulted in:
https://tbpl.mozilla.org/php/getParsedLog.php?id=44356812&tree=Mozilla-Inbound
{
make[5]: Entering directory `/builds/slave/m-in-lx-d-00000000000000000000/build/obj-firefox/image/decoders/icon/gtk'
make[5]: Nothing to be done for `export'.
make[5]: Leaving directory `/builds/slave/m-in-lx-d-00000000000000000000/build/obj-firefox/image/decoders/icon/gtk'
Traceback (most recent call last):
File "/builds/slave/m-in-lx-d-00000000000000000000/build/dom/bindings/GenerateCSS2PropertiesWebIDL.py", line 8, in <module>
propList = eval(sys.stdin.read())
File "<string>", line 1
Start server
^
SyntaxError: invalid syntax
make[5]: *** [CSS2Properties.webidl] Error 1
make[5]: *** Deleting file `CSS2Properties.webidl'
make[5]: Leaving directory `/builds/slave/m-in-lx-d-00000000000000000000/build/obj-firefox/dom/bindings'
make[4]: *** [dom/bindings/export] Error 2
make[4]: *** Waiting for unfinished jobs...
}
Reporter | ||
Comment 1•10 years ago
|
||
Mike, would you mind taking a look - given this seems like it's a result of scache?
Flags: needinfo?(mh+mozilla)
Comment 2•10 years ago
|
||
FWIW: I'm guessing this was triggered by my (minimal) tweak to nsCSSPropList.h, in this cset:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5988d4a17c59
since that .h file is our source-of-truth for what properties exist. (I don't actually know how GenerateCSS2PropertiesWebIDL.py works, but I'll bet it uses that file.)
Comment 3•10 years ago
|
||
Since the "Start server" string caused other issues as well (like bug 1019955), we should probably just remove it, or at least print it to stderr as suggested in https://bugzilla.mozilla.org/show_bug.cgi?id=1019955#c14
Comment 4•10 years ago
|
||
Hit this bug this evening, touched CLOBBER to fix:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=3928403b6627
Comment 5•10 years ago
|
||
If it happens again, please do *not* solve it with a CLOBBER update, because it only affects automation, no need to have everyone clobber.
Flags: needinfo?(mh+mozilla)
Reporter | ||
Comment 6•10 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #5)
> If it happens again, please do *not* solve it with a CLOBBER update, because
> it only affects automation, no need to have everyone clobber.
Not using the CLOBBER file isn't practical, since manually clobbering automation machines (say all trees at once) doesn't help when the change merges to other trees (trees that have since re-built builds on old csets since the mass-clobber). In-lieu of an automation-only CLOBBER file (I've added this to bug 1043262), we should just set a CLOBBER file message of "Automation-only clobber, please override locally" etc.
Comment 7•10 years ago
|
||
Merges are less likely to trigger this.
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•