Closed Bug 1042175 Opened 10 years ago Closed 10 years ago

[B2G][FM Radio] Favorite stations duplicated after toggling airplane mode on then off while FM radio with favorite stations is open

Categories

(Firefox OS Graveyard :: Gaia::FMRadio, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::FMRadio
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v1.4 unaffected, b2g-v2.0 affected, b2g-v2.1 affected)

Status:
RESOLVED DUPLICATE of bug 1042478
Tracking Flags:
Tracking Status
b2g-v1.4 --- unaffected
b2g-v2.0 --- affected
b2g-v2.1 --- affected

People

(Reporter: bzumwalt, Assigned: pzhang)

References

(
URL
)

Details

(Keywords: regression, Whiteboard: [2.0-flame-test-run-3])

Attachments

(2 files)

Logcat
50.08 KB, text/plain
Details
PR 22055
52 bytes, text/plain
timdream
: feedback+
Details
Attached file Logcat — 
Description:
All favorited radio stations in FM Radio are duplicated 7 times each when user turns on airplane mode when listening to FM Radio, then toggles airplane mode off. Restarting phone removes duplicates.

Repro Steps:
1) Update a Flame to 20140721000201
2) Launch FM Radio with at least two favorite stations
3) Select one of the favorite stations and press homescreen
4) Enable airplane mode from Notification Tray
5) Select FM Radio icon from Homescreen
6) Disable airplane mode from Notification Tray

Actual:
6 additional copies of your favorite FM Radio stations are listed after disabling airplane mode.

Expected:
After disabling airplane mode the FM Radio UI appears normal.

Environmental Variables:
Device: Flame 2.0 (273mb)
Build ID: 20140721000201
Gaia: 8cb1a949f2e9650bb2c5598e78a6f24a58bbaf97
Gecko: 4bd4b0ae7bbe
Version: 32.0a2 (2.0) 
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Notes:
Repro frequency: 3/3, 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/8464/
See attached: Youtube video clip and  logcat
Youtube link: http://youtu.be/V297MO9gscI
Issue DOES occur on 2.1 Flame (273mb), 2.1 Open C, 2.0 Flame (512mb), 2.0 Open C, and 1.4 Open C

Environmental Variables:
Device: flame 2.1 (273mb)
BuildID: 20140721062116
Gaia:
Gecko: 0dc711216018
Version: 33.0a1
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Environmental Variables:
Device: Open_C Master
Build ID: 20140721062116
Gaia: Unknown
Gecko: 0dc711216018
Version: 33.0a1 (Master)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Environmental Variables:
Device: Flame 2.0 (512mb)
Build ID: 20140721000201
Gaia: 8cb1a949f2e9650bb2c5598e78a6f24a58bbaf97
Gecko: 4bd4b0ae7bbe
Version: 32.0a2 (2.0)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Environmental Variables:
Device: Open_C 2.0
Build ID: 20140721000201
Gaia: 8cb1a949f2e9650bb2c5598e78a6f24a58bbaf97
Gecko: 4bd4b0ae7bbe
Version: 32.0a2 (2.0)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Environmental Variables:
Device: Open_C 1.4
Build ID: 20140721000201
Gaia: 621d152f89347c79619aa909ad62cc2ac9d3ab5b
Gecko: 83b7be7fb33f
Version: 30.0 (1.4)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Actual Results: 6 additional copies of your favorite FM Radio stations are listed after disabling airplane mode.


Issue does NOT occur on 2.1 Buri, 2.0 Buri, 1.4 Flame (273mb), 1.4 Buri

v2.1 Environmental Variables:
Device: Buri 2.1 Master
BuildID: 20140721062116
Gaia: Unknown
Gecko: 0dc711216018
Version:  33.0a1
Firmware Version: v1.2-device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Environmental Variables:
Device: Buri 2.0
Build ID: 20140721003002
Gaia: 8cb1a949f2e9650bb2c5598e78a6f24a58bbaf97
Gecko: 4bd4b0ae7bbe
Version: 32.0a2 (2.0) MOZ
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Environmental Variables:
Device: Flame 1.4 (273mb)
Build ID: 20140721000201
Gaia: 621d152f89347c79619aa909ad62cc2ac9d3ab5b
Gecko: 83b7be7fb33f
Version: 30.0 (1.4)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Environmental Variables:
Device: Buri 1.4
Build ID: 20140721000201
Gaia: 621d152f89347c79619aa909ad62cc2ac9d3ab5b
Gecko: 83b7be7fb33f
Version: 30.0 (1.4)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Actual Result: After disabling airplane mode the FM Radio UI appears normal.
QA Whiteboard: [QAnalyst-Triage?]
status-b2g-v1.4: --- → affected
status-b2g-v2.1: --- → affected
Flags: needinfo?(ktucker)
Issue also occurs with following repro steps:

1) Launch FM radio with at least one favorited radio station present
2) Select a favorite radio station
3) Enable then disable airplane mode through notification tray

Actual:
6 additional copies of your favorite FM Radio stations are listed after disabling airplane mode. Unfavoriting does not remove duplicate radio stations until user closes app.

Expected:
After disabling airplane mode the FM Radio UI appears normal.
This is a regression from 1.4 but doesn't seem to break functionality. If the user closes the app, the duplicate favorite stations will be removed so not nominating this as a potential blocker.
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Keywords: regression
(In reply to KTucker (:KTucker) from comment #3)
> This is a regression from 1.4 but doesn't seem to break functionality. If
> the user closes the app, the duplicate favorite stations will be removed so
> not nominating this as a potential blocker.

I will take a look at this.
Assignee: nobody → pzhang
Printed some logs in apps/fm/js/fm.js, it turns out |AirplaneModeHelper.ready| is invoked several times when enabling airplane mode:

E/GeckoConsole( 2709): Content JS LOG at app://fm.gaiamobile.org/js/fm.js:171 in updatePowerUI: Power status: on
E/GeckoConsole( 2709): Content JS LOG at app://fm.gaiamobile.org/js/fm.js:675 in favoritesList.add: favoritesList.add: 87.6
E/GeckoConsole( 2709): Content JS LOG at app://fm.gaiamobile.org/js/fm.js:675 in favoritesList.add: favoritesList.add: 88.7
E/GeckoConsole( 2709): Content JS LOG at app://fm.gaiamobile.org/js/fm.js:675 in favoritesList.add: favoritesList.add: 90
E/GeckoConsole( 2709): Content JS LOG at app://fm.gaiamobile.org/js/fm.js:675 in favoritesList.add: favoritesList.add: 90.5
E/GeckoConsole( 2709): Content JS LOG at app://fm.gaiamobile.org/js/fm.js:890 in anonymous: AirplaneModeHelper.ready.
E/GeckoConsole( 2709): Content JS LOG at app://fm.gaiamobile.org/js/fm.js:718 in init: init.
E/GeckoConsole( 2709): Content JS LOG at app://fm.gaiamobile.org/js/fm.js:812 in init/<: AirplaneModeHelper.statechange
E/GeckoConsole( 2709): Content JS LOG at app://fm.gaiamobile.org/js/fm.js:171 in updatePowerUI: Power status: on
E/GeckoConsole( 2709): Content JS LOG at app://fm.gaiamobile.org/js/fm.js:553 in favoritesList.init: favoritesList.init
E/GeckoConsole( 2709): Content JS LOG at app://fm.gaiamobile.org/js/fm.js:171 in updatePowerUI: Power status: on
E/GeckoConsole( 2709): Content JS LOG at app://fm.gaiamobile.org/js/fm.js:171 in updatePowerUI: Power status: on
E/GeckoConsole( 2709): Content JS LOG at app://fm.gaiamobile.org/js/fm.js:890 in anonymous: AirplaneModeHelper.ready.
E/GeckoConsole( 2709): Content JS LOG at app://fm.gaiamobile.org/js/fm.js:718 in init: init.
E/GeckoConsole( 2709): Content JS LOG at app://fm.gaiamobile.org/js/fm.js:812 in init/<: AirplaneModeHelper.statechange
E/GeckoConsole( 2709): Content JS LOG at app://fm.gaiamobile.org/js/fm.js:812 in init/<: AirplaneModeHelper.statechange
E/GeckoConsole( 2709): Content JS LOG at app://fm.gaiamobile.org/js/fm.js:171 in updatePowerUI: Power status: on
E/GeckoConsole( 2709): Content JS LOG at app://fm.gaiamobile.org/js/fm.js:553 in favoritesList.init: favoritesList.init
E/GeckoConsole( 2709): Content JS LOG at app://fm.gaiamobile.org/js/fm.js:171 in updatePowerUI: Power status: on
E/GeckoConsole( 2709): Content JS LOG at app://fm.gaiamobile.org/js/fm.js:171 in updatePowerUI: Power status: on
E/GeckoConsole( 2709): Content JS LOG at app://fm.gaiamobile.org/js/fm.js:890 in anonymous: AirplaneModeHelper.ready.
E/GeckoConsole( 2709): Content JS LOG at app://fm.gaiamobile.org/js/fm.js:718 in init: init.
E/GeckoConsole( 2709): Content JS LOG at app://fm.gaiamobile.org/js/fm.js:812 in init/<: AirplaneModeHelper.statechange
E/GeckoConsole( 2709): Content JS LOG at app://fm.gaiamobile.org/js/fm.js:812 in init/<: AirplaneModeHelper.statechange
E/GeckoConsole( 2709): Content JS LOG at app://fm.gaiamobile.org/js/fm.js:812 in init/<: AirplaneModeHelper.statechange
E/GeckoConsole( 2709): Content JS LOG at app://fm.gaiamobile.org/js/fm.js:171 in updatePowerUI: Power status: off
E/GeckoConsole( 2709): Content JS LOG at app://fm.gaiamobile.org/js/fm.js:553 in favoritesList.init: favoritesList.init
E/GeckoConsole( 2709): Content JS LOG at app://fm.gaiamobile.org/js/fm.js:171 in updatePowerUI: Power status: off
Filed bug 1042478 to fix AirplaneModeHelper.ready issue.
Attached file PR 22055 — 

        Attachment #8460716 -
        Flags: review?(timdream)

    
    

    
  
Comment on attachment 8460716 [details]
PR 22055

It is probably make more sense to wait for bug 1042478 than workaround there.

        Attachment #8460716 -
        Flags: feedback+

    
    

    
  
(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #8)
> Comment on attachment 8460716 [details]
> PR 22055
> 
> It is probably make more sense to wait for bug 1042478 than workaround there.

Provided a patch for bug 1042478, let's close this.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: