Closed Bug 1042212 Opened 10 years ago Closed 4 years ago

factor out empty stuff stuff in code+tests

Categories

(Release Engineering Graveyard :: Applications: Balrog (backend), defect, P3)

Product:
Release Engineering Graveyard
Component:
Applications: Balrog (backend)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: bhearsum, Unassigned)

Details

(Whiteboard: [lang=python]) 

There's quite a few places in Balrog code and tests that deal with empty xml responses. We have a few blocks like:
xml = ['<?xml version="1.0"?>']
xml.append('<updates>')
xml.append('</updates>')
xml = "\n".join(xml)

And similar blocks that test for an update xml.

We should factor both of these out somewhere common to reduce that duplication. It's gonna suck if an empty response ever looks different than it currently does.
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1951]
Mentor: bhearsum
Priority: -- → P3
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1951] → [lang=python]
Mentor: bhearsum

Probably not worth doing unless the empty response does change at some point. We can look at addressing it then, if we want to.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
Product: Release Engineering → Release Engineering Graveyard
You need to log in before you can comment on or make changes to this bug.