Closed Bug 1042241 Opened 10 years ago Closed 10 years ago

Avoid unnecessarily encoding and decoding a canvas to png image before painting it

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Homescreen
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.1+, b2g-v2.0 wontfix, b2g-v2.0M fixed, b2g-v2.1 fixed, b2g-v2.1S fixed, b2g-v2.2 fixed)

Status:
RESOLVED FIXED
Milestone:
2.1 S6 (10oct)
Project Flags:
blocking-b2g 2.1+
Tracking Flags:
Tracking Status
b2g-v2.0 --- wontfix
b2g-v2.0M --- fixed
b2g-v2.1 --- fixed
b2g-v2.1S --- fixed
b2g-v2.2 --- fixed

People

(Reporter: jrmuizel, Assigned: jrmuizel)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

Avoid unnecessarily encoding and decoding a canvas to png image before painting it
46 bytes, text/x-github-pull-request
kgrandon
: review+
bajaj
: approval-gaia-v2.1+
Details | Review 
      No description provided.
Assignee: nobody → jmuizelaar
Comment on attachment 8460410 [details] [review]
Avoid unnecessarily encoding and decoding a canvas to png image before painting it

This looks much better, thanks!
Attachment #8460410 - Flags: review?(kgrandon) → review+
Blocks: vertical-home-next
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking-]
Whiteboard: [systemsfe]
(In reply to Kevin Grandon :kgrandon from comment #2)
> Comment on attachment 8460410 [details] [review]
> Avoid unnecessarily encoding and decoding a canvas to png image before
> painting it
> 
> This looks much better, thanks!

Any chance this can get landed?
Flags: needinfo?(kgrandon)
(In reply to Jeff Muizelaar [:jrmuizel] from comment #3)
> Any chance this can get landed?

Yes! Sorry about forgetting. Generally you can also use the checkin-needed keyword, but I'll go ahead and land this.

https://github.com/mozilla-b2g/gaia/commit/ebb56bdb10a9bf541296b3671928d83990569996
Status: NEW → RESOLVED
Closed: 10 years ago
status-b2g-v2.0: --- → affected
status-b2g-v2.0M: --- → affected
status-b2g-v2.1: --- → affected
status-b2g-v2.2: --- → fixed
Flags: needinfo?(kgrandon)
Resolution: --- → FIXED
blocking-b2g: --- → 2.0M?
Blocks: Woodduck
Triage:
Hi Kai-Zhen,
2.0M+ . PLease help. Thanks!
blocking-b2g: 2.0M? → 2.0M+
Flags: needinfo?(kli)
OK, will merge into v2.0 when tree is opened. Keep ni.
Kevin, can you set the 2.1 status flag to wontfix if this is not needed in 2.1?
Flags: needinfo?(khu)
Triage:
Hi Vincent,
Kevin and Keven has approved to land this on 2.1.
Can you help to see whether the patch is able to land on 2.1? Thanks!
blocking-b2g: 2.0M+ → 2.1+
status-b2g-master: --- → fixed
Flags: needinfo?(khu) → needinfo?(vliu)
Hi Jeff,
Could you help to raise patch approval for landing this on 2.1?
Thanks!
Flags: needinfo?(vliu) → needinfo?(jmuizelaar)
Comment on attachment 8460410 [details] [review]
Avoid unnecessarily encoding and decoding a canvas to png image before painting it

[Approval Request Comment]
[User impact] if declined: Wasted CPU time
[Testing completed]: is in 2.0
[Risk to taking this patch] (and alternatives if risky): Should be low.
Flags: needinfo?(jmuizelaar)
Attachment #8460410 - Flags: approval-gaia-v2.1?
status-b2g-v2.0: affected → wontfix
status-b2g-master: fixed → ---
Target Milestone: --- → 2.1 S6 (10oct)
Attachment #8460410 - Flags: approval-gaia-v2.1? → approval-gaia-v2.1+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: