Closed
Bug 1042268
Opened 10 years ago
Closed 10 years ago
"Show All Bookmarks" item of Bookmarks widget dropdown is almost invisible in High contrast themes
Categories
(Firefox :: Theme, defect)
Tracking
()
People
(Reporter: alice0775, Assigned: alexbardas, Mentored)
References
Details
(Keywords: access, regression, Whiteboard: [lang=css][good first bug])
Attachments
(3 files, 3 obsolete files)
Steps To Reproduce: 1. Set High contrast themes in windows7 visual style 2. Open Firefox 3. Open Bookmarks widget dropdown Actual Results: "Show All Bookmarks" is almost invisible Expected Results: High contrast themes should be applied to "Show All Bookmarks"
Reporter | ||
Updated•10 years ago
|
Summary: "Show All Bookmarks" item of Bookmarks widget dropdown in → "Show All Bookmarks" item of Bookmarks widget dropdown is almost invisible in High contrast themes
Reporter | ||
Comment 1•10 years ago
|
||
[Tracking Requested - why for this release]:
status-firefox31:
--- → affected
status-firefox32:
--- → affected
status-firefox33:
--- → affected
status-firefox34:
--- → affected
status-firefox-esr24:
--- → unaffected
status-firefox-esr31:
--- → affected
tracking-firefox32:
--- → ?
tracking-firefox33:
--- → ?
tracking-firefox34:
--- → ?
tracking-firefox-esr31:
--- → ?
Comment 2•10 years ago
|
||
Is this a regression from Australis?
tracking-firefox34:
? → ---
Flags: needinfo?(alice0775)
Reporter | ||
Comment 3•10 years ago
|
||
Regression window(fx) Good: https://hg.mozilla.org/integration/fx-team/rev/ab6e51e115bc Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0 ID:20140312153345 Bad: https://hg.mozilla.org/integration/fx-team/rev/c8a1458bfe7d Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0 ID:20140312153843 Pushlog: http://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=ab6e51e115bc&tochange=c8a1458bfe7d Triggered by: 1a9fa8fde7e0 Darrin Henein — Bug 969592 - Restyle Australis' Bookmarks Menu Popups, r=mak
Updated•10 years ago
|
Flags: firefox-backlog?
Updated•10 years ago
|
Flags: firefox-backlog? → firefox-backlog+
Updated•10 years ago
|
Points: --- → 3
QA Whiteboard: [qa+]
Comment 4•10 years ago
|
||
With no progress in the past few weeks, I'm marking 32 as won't fix. Gavin - Do you think this issue is important enough to track? If so, can you please help get this prioritized into an upcoming iteration in order to address the issue in Firefox 33?
Flags: needinfo?(gavin.sharp)
Comment 5•10 years ago
|
||
I don't think we need to track it, but we should fix it soon. Jared, can you mentor this or suggest someone who can?
Flags: needinfo?(gavin.sharp) → needinfo?(jaws)
Comment 6•10 years ago
|
||
We should be able to change the color value from #000 to MenuText at http://hg.mozilla.org/mozilla-central/annotate/4d94eeca89f3/browser/themes/windows/customizableui/panelUIOverlay.css#l45 to fix this bug. Will need some manual testing to verify though.
Mentor: jaws
Flags: needinfo?(jaws)
Whiteboard: [lang=css][good first bug]
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → abardas
Status: NEW → ASSIGNED
Assignee | ||
Comment 7•10 years ago
|
||
Attachment #8475309 -
Flags: review?(jaws)
Assignee | ||
Comment 8•10 years ago
|
||
I've also attached a screenshot with the patch applied.
Comment 9•10 years ago
|
||
Comment on attachment 8475309 [details] [diff] [review] bug1042268_show_all_bookmarks_in_bookmarks_widget_dropdown_is_invisible_in_high_contrast_themes.diff Review of attachment 8475309 [details] [diff] [review]: ----------------------------------------------------------------- Dao, do you see any issues with making this change?
Attachment #8475309 -
Flags: review?(jaws) → review?(dao)
Updated•10 years ago
|
Iteration: --- → 34.3
QA Whiteboard: [qa+]
Flags: qe-verify+
Updated•10 years ago
|
QA Contact: andrei.vaida
Comment 10•10 years ago
|
||
Comment on attachment 8475309 [details] [diff] [review] bug1042268_show_all_bookmarks_in_bookmarks_widget_dropdown_is_invisible_in_high_contrast_themes.diff Review of attachment 8475309 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/themes/windows/customizableui/panelUIOverlay.css @@ +41,5 @@ > padding-top: 4px; > } > > #BMB_bookmarksPopup .menu-text { > + color: menutext; Actually, it looks like this rule can just be deleted. With it deleted, the text will work like the rest of the menuitems. Sorry for the runaround.
Attachment #8475309 -
Flags: review?(dao) → review-
Assignee | ||
Comment 11•10 years ago
|
||
That rule is not even applied for osx / linux themes and does the trick, so it's ok to be removed.
Attachment #8475309 -
Attachment is obsolete: true
Attachment #8476844 -
Flags: review?(dao)
Updated•10 years ago
|
Attachment #8476844 -
Flags: review?(dao) → review+
Updated•10 years ago
|
Keywords: checkin-needed
Comment 12•10 years ago
|
||
Comment on attachment 8476844 [details] [diff] [review] Remove css rule which makes 'Show all bookmarks' button hardly visible in High Contrast themes >-#BMB_bookmarksPopup .menu-text { >- color: #000; >-} >- > #BMB_bookmarksPopup .subviewbutton[disabled=true] > .menu-text { > color: #6d6d6d; > } What's the point of the hardcoded color for the disabled state? Shouldn't that be removed just like for the enabled state?
Updated•10 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 13•10 years ago
|
||
How can I get to a state where "Show all bookmarks" is disabled?
Flags: needinfo?(dao)
Comment 14•10 years ago
|
||
I think "subscribe to page" is the only subviewbutton in that menu that gets disabled.
Assignee | ||
Comment 15•10 years ago
|
||
Attachment #8475313 -
Attachment is obsolete: true
Assignee | ||
Comment 16•10 years ago
|
||
On windows, there are multiple problems with the bookmarks dropdown menu and all other submenus (see bookmark-submenu.png). I'd like to also fix those submenus in the next patch. The problem lies here: http://mxr.mozilla.org/mozilla-central/source/browser/themes/windows/customizableui/panelUIOverlay.css#26
Flags: needinfo?(dao)
Assignee | ||
Comment 17•10 years ago
|
||
There is another bug which has an attached patch addressing the submenus (bug 1008603), so that part is outside this bug's scope.
Attachment #8476844 -
Attachment is obsolete: true
Attachment #8477584 -
Flags: review?(dao)
Updated•10 years ago
|
Attachment #8477584 -
Flags: review?(dao) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 18•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/fcafd91816f7
Keywords: checkin-needed
Whiteboard: [lang=css][good first bug] → [lang=css][good first bug][fixed-in-fx-team]
Comment 19•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fcafd91816f7
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [lang=css][good first bug][fixed-in-fx-team] → [lang=css][good first bug]
Target Milestone: --- → Firefox 34
Comment 20•10 years ago
|
||
Verified fixed on Nightly 34.0a1 (2014-08-27) using Windows 7 64-bit along with all the available high-contrast themes. The sub-menu issue depicted in attachment 8477536 [details] is still visible though, but I suppose that's being taken care of in Bug 1042263.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•