Closed Bug 1042295 Opened 6 years ago Closed 6 years ago

Change in Linux OMTC activation

Categories

(Core :: Graphics: Layers, defect)

All
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34
Tracking Status
firefox33 + fixed
firefox34 + fixed

People

(Reporter: heftig, Assigned: heftig)

Details

Attachments

(2 files)

[Tracking Requested - why for this release]:

https://hg.mozilla.org/mozilla-central/rev/bb0c777636e9 (bug 774388 patch 4) changed the logic how OMTC can be enabled on Linut. The environment variables now enable OMTC on nightly builds, instead of allowing OMTC to be enabled on non-nightly builds.

It also missed the XInitThreads() call in nsAppRunner.cpp, so now enabling OMTC on non-nightly builds without setting the env vars could cause haywire due to missing thread-safety.

Patch follows.
This patch should restore the previous behavior on Linux, where OMTC support is masked by the env vars when not on nightly builds.
Attachment #8460528 - Flags: review?(bjacob)
Comment on attachment 8460528 [details] [diff] [review]
0001-Bug-1042295-Change-in-Linux-OMTC-activation.patch

Nical, forwarding this review request to you because this changes how we decide whether to use OMTC on Linux, something you've been looking at recently.
Attachment #8460528 - Flags: review?(bjacob) → review?(nical.bugzilla)
Comment on attachment 8460528 [details] [diff] [review]
0001-Bug-1042295-Change-in-Linux-OMTC-activation.patch

Review of attachment 8460528 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch!
Attachment #8460528 - Flags: review?(nical.bugzilla) → review+
Can this patch get pushed, please? Aurora 33 is actively affected by this bug.
Jan, could you change your hg setup to remove the quotes in the commit header?

user:        "Jan Alexander Steffens (heftig)" <jan.steffens@gmail.com>

should be:

user:        Jan Alexander Steffens (heftig) <jan.steffens@gmail.com>

We usually don't put the nick name as you do in parenthesis but that's not a problem (the quotes confuse our automation setup).

Thanks!
Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: Activating OMTC can cause aurora to crash on linux
[Describe test coverage new/current, TBPL]:
[Risks and why]: low, does not affect firefox with default prefs
[String/UUID change made/needed]:
Attachment #8466169 - Flags: approval-mozilla-aurora?
(In reply to Nicolas Silva [:nical] from comment #6)
> Jan, could you change your hg setup to remove the quotes in the commit
> header?
> 
> user:        "Jan Alexander Steffens (heftig)" <jan.steffens@gmail.com>
> 
> should be:
> 
> user:        Jan Alexander Steffens (heftig) <jan.steffens@gmail.com>
> 
> We usually don't put the nick name as you do in parenthesis but that's not a
> problem (the quotes confuse our automation setup).
> 
> Thanks!

Ah, sorry. If you look closer you'll notice the patch was generated by git, not hg, and is in its typical email format.

I'm not sure why it insists on the quotes; maybe the parentheses have something to do with it. I'll look into it.
https://hg.mozilla.org/mozilla-central/rev/8ba5b2460e82
Assignee: nobody → jan.steffens
Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Attachment #8466169 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.