1042327 - Fix pixman bug workaround properly

Status: NEW

(Core :: Graphics, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1022612#c97.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Use a more narrow workaround for pixman bug

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3f9060993657

Comment 3

[Ed Morley [:emorley]]

Unfortunately I've had to back out the push that contained this, for turning mochitest-1 orange on debug OS X. Nothing appears in the brief log annoyingly, eg:
https://tbpl.mozilla.org/php/getParsedLog.php?id=44517570&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=44517238&tree=Mozilla-Inbound

And the full log just helpfully states:
07:21:55     INFO -  41242 INFO TEST-START | Shutdown
07:21:55     INFO -  41243 INFO Passed:  140694
07:21:55  WARNING -  41244 INFO Failed:  1
07:21:55  WARNING -  One or more unittests failed.

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/7bba153bad82
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/3067c3b55a51

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1041530#c17

I guess pixman-regions have other bugs that this patch fails to work around but the code currently in the tree does.