Closed
Bug 1042331
Opened 10 years ago
Closed 10 years ago
Rounded text field borders are wrong on Mac OSX 10.10
Categories
(Core :: Widget: Cocoa, defect)
Tracking
()
VERIFIED
FIXED
mozilla34
People
(Reporter: u279076, Assigned: mstange)
References
(Blocks 1 open bug)
Details
(Whiteboard: [yosemite])
Attachments
(3 files)
Screenshot: Firefox
In Mac OSX 10.10 there are two borders on a text field, the traditional "blue glow" and a tiny inner black border. I'm attaching a screenshot to illustrate this comparing Firefox Nightly to Safari. The new border is a rounded rectangle whereas Firefox still uses the ellipse shape.
To reproduce what I'm seeing in the screenshot in Yosemite:
1. Nightly menu > Preferences
2. Privacy panel
3. Remove individual cookies link
4. Look at the Search field
5. In Safari, open Preferences > Passwords and look at the search field.
> Firefox: black rounded rectangle border seems to overlap blue ellipse border
> Safari: black rounded rectangle border aligns properly with blue rounded rectangle border
Screenshots to follow.
|
||
Updated•10 years ago
|
Blocks: theme-yosemite
|
||
Updated•10 years ago
|
Component: General → Widget: Cocoa
Product: Toolkit → Core
|
|
||
Updated•10 years ago
|
Summary: Text field border is misaligned in Mac OSX 10.10 → Rounded text field borders are wrong on Mac OSX 10.10
|
Assignee | |
Comment 3•10 years ago
|
||
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8474820 [details] [diff] [review] fix This looks fine to me. But could you put the code common to -[SearchFieldCellWithFocusRing drawWithFrame:inView:] and DrawCellIncludingFocusRing() into a static helper method?
Attachment #8474820 -
Flags: review?(smichaud) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Factored that out to DrawFocusRingForCellIfNeeded. https://hg.mozilla.org/integration/mozilla-inbound/rev/0e1e544214cd
|
||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0e1e544214cd
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Flagging this for me to verify with tomorrow's Nightly.
Flags: qe-verify+
Flags: needinfo?(anthony.s.hughes)
QA Contact: anthony.s.hughes
This looks fine to me now in Nightly. Thanks.
Status: RESOLVED → VERIFIED
Flags: needinfo?(anthony.s.hughes)
You need to log in
before you can comment on or make changes to this bug.
Description
•