Entering a name metadata block leads to 'Oops' page

VERIFIED FIXED in 2014-08

Status

()

Toolkit
Blocklisting
P1
major
VERIFIED FIXED
4 years ago
2 years ago

People

(Reporter: jorgev, Assigned: magopian)

Tracking

unspecified
2014-08
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

4 years ago
I was going to test the new extension block types in -dev to make sure there weren't any problems, but I ran into a problem.

STR:
1) Go to https://addons-dev.allizom.org/en-US/admin/models/blocklist/blocklistdetail/add/
2) Enter anything you want in Name, Why, Who, and a valid bug link in Bug.
3) Enter the following under Blocklist Item #1:
Min: 0
Max: *
Severity: 1
Name: /Shop_an_Up/
4) Don't enter anything else and click on Save.

Expected:
Block should be saved.

Observed:
'Oops' page shown and no block added.
The issue seems to be that, while the admin form allows an empty GUID, the ORM attempts to store it in the DB as NULL, rather than '', even though it's a NOT NULL column.

Using a regexp like /.*/ for the GUID should work for now, but this should definitely still be fixed.
(Reporter)

Updated

4 years ago
Depends on: 1001375
(Assignee)

Comment 3

4 years ago
Fixed in https://github.com/mozilla/olympia/commit/4c1f0c483db1f48a00566dca7956cd59c8b1dc1b
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Comment 4

4 years ago
Verified as fixed.
Postfix screencast: http://screencast.com/t/gSu5WWWb
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → Toolkit
You need to log in before you can comment on or make changes to this bug.