1042396 - "ASSERTION: Wrong Document Channel" with iframe src swap, proxy settings

Status: VERIFIED FIXED

(Core :: Networking, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: Wrong Document Channel: 'request == mDocumentRequest', file uriloader/base/nsDocLoader.cpp, line 1443

Comment 1

[Jesse Ruderman]

Attachment: proxy settings

One way to create a new profile using this prefs:

1. mkdir -p ~/px/a/
2. cp proxy-prefs.js ~/px/a/prefs.js
3. firefox -profile ~/px/a/ testcase.html

Comment 2

[Jesse Ruderman]

Attachment: stack

Comment 3

[Boris Zbarsky [:bzbarsky]]

Hmm.  When this redirect happens, is the old channel an FTP or HTTP channel?

Because nsAsyncRedirectVerifyHelper::IsOldChannelCanceled only treats as canceled things that QI to nsIHttpChannelInternal, and my best hypothesis given the testcase is that the fact that we cancel the first channel gets ignored and we get a redirect notification for it anyway.

Comment 4

[Honza Bambas (:mayhemer)]

And since when our FTP channel can start a redirect?  I'll try to reproduce with the test case (not sooner than the next week).

Comment 5

[Honza Bambas (:mayhemer)]

(In reply to Jesse Ruderman from comment #1)
> Created attachment 8460636 [details]
> proxy settings
> 
> One way to create a new profile using this prefs:
> 
> 1. mkdir -p ~/px/a/
> 2. cp proxy-prefs.js ~/px/a/prefs.js
> 3. firefox -profile ~/px/a/ testcase.html

I need more info on how to use the test case.  Does testcase.html have to be hosted?  Do I need a proxy?

Only thing I'm getting in the iframe is "The proxy server is refusing connections" any way I'm try to load it.

But I believe what Boris says is true (how else :)))  So the patch can be based on his comment and just given to you (Jesse) for testing.

Comment 6

[Honza Bambas (:mayhemer)]

Attachment: potential patch v1

- check if a non-http channel is canceled by checking its status
- based on bz's comment 3

 https://tbpl.mozilla.org/?tree=Try&rev=3e588114da68

Comment 7

[Patrick McManus [:mcmanus]]

Comment on attachment 8503163 [details] [diff] [review]
potential patch v1

Review of attachment 8503163 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/base/src/nsAsyncRedirectVerifyHelper.cpp
@@ +270,5 @@
> +        // indicates the channel has probably been canceled.
> +        nsresult status = NS_ERROR_FAILURE;
> +        mOldChan->GetStatus(&status);
> +        if (NS_FAILED(status)) {
> +            return false;

return true, right? (otherwise I can't see how this patch has any effect).

Comment 8

[Honza Bambas (:mayhemer)]

Attachment: v2

Yes!

https://tbpl.mozilla.org/?tree=Try&rev=cf0d84ad9bab

Comment 9

[Honza Bambas (:mayhemer)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ce2ed57db64e

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ce2ed57db64e

Comment 11

[Jesse Ruderman]

> I need more info on how to use the test case.  Does testcase.html have to be
> hosted?  Do I need a proxy?

testcase.html should be a local file. You don't need a proxy, but you do need the "proxy settings" that tell Firefox to try to connect to localhost on a bogus port.

> Only thing I'm getting in the iframe is "The proxy server is refusing
> connections" any way I'm try to load it.

I think that's the expected behavior.

I'm no longer seeing the assertion with a new build, so V FIXED.