Closed Bug 1042414 Opened 10 years ago Closed 10 years ago

Changing an AC_DEFINE'ed variable in configure.in can require clobbers for preprocessed files

Categories

(Firefox Build System :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla34

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I had a partially built tree and I hacked configure.in to make sure that MOZ_MEMORY is not set, and I rebuilt without clobbering.  I saw linking failures in mozglue.dll which boiled down to mozglue.def not being regenerated (it depends on #ifdef MOZ_MEMORY.)  rm-ing mozglue.def and rebuilding fixed the issue.
That's a very generic bug summary. Are you sure you don't just want to fix the issue with mozglue.def?
In fact, most preprocessed files have the "proper" dependencies to avoid that. mozglue.def doesn't depend on $(GLOBAL_DEPS)
Ah, I see.  I thought this could be a more wide-spread issue...
Assignee: nobody → ehsan
Attachment #8465663 - Flags: review?(mh+mozilla)
Attachment #8465663 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/ba8e403bd822
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
QA Whiteboard: [qa-]
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: