Closed
Bug 1042414
Opened 10 years ago
Closed 10 years ago
Changing an AC_DEFINE'ed variable in configure.in can require clobbers for preprocessed files
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla34
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
857 bytes,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
I had a partially built tree and I hacked configure.in to make sure that MOZ_MEMORY is not set, and I rebuilt without clobbering. I saw linking failures in mozglue.dll which boiled down to mozglue.def not being regenerated (it depends on #ifdef MOZ_MEMORY.) rm-ing mozglue.def and rebuilding fixed the issue.
Comment 1•10 years ago
|
||
That's a very generic bug summary. Are you sure you don't just want to fix the issue with mozglue.def?
Comment 2•10 years ago
|
||
In fact, most preprocessed files have the "proper" dependencies to avoid that. mozglue.def doesn't depend on $(GLOBAL_DEPS)
Assignee | ||
Comment 3•10 years ago
|
||
Ah, I see. I thought this could be a more wide-spread issue...
Assignee: nobody → ehsan
Assignee | ||
Comment 4•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8465663 -
Flags: review?(mh+mozilla)
Updated•10 years ago
|
Attachment #8465663 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba8e403bd822
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ba8e403bd822
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ba8e403bd822
Updated•10 years ago
|
QA Whiteboard: [qa-]
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•