1042466 - logviewer: List of buildsteps is unusable in some screen/font sizes

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Mike Hommey [:glandium]]

Attachment: Screenshot

If the font is too large compared to the window width, the list of steps ends up below the properties list, and it ends up showing only one step, which makes it very hard to use. And the button for raw logs is just invisible.

See attached screenshot.

Comment 1

[Mike Hommey [:glandium]]

FWIW, the window width is such because it's exactly half of 1920, which is the horizontal resolution of my screen.

Comment 2

[Jonathan French (:jfrench)]

I'll have a look at this and see what I can do.

Comment 3

[Jonathan French (:jfrench)]

There are some interesting UI regressions that occur in the structured log attempting to remove the absolute and fixed css properties of lv-log-container and run-data to make them responsive to a narrower page flow. Correct location scrolling via scrollTo() and also loadMore() aren't evident, and related we lose the container specific scroll bar, among other issues. Still looking at it.

Comment 4

[Jonathan French (:jfrench)]

With Camd's help we made some more progress. All failure steps and most of the passed steps are navigating to the correct log position. I'm still trying to sort out infinite scroll in the log container (new chunks are not being triggered when hitting the boundary) and the first 2-3 passed step-links in log steps aren't scrolling to the correct point in the log - when the browser is narrow.

Comment 5

[Jonathan French (:jfrench)]

Turns out my approach was a dead end, and :camd stepped in and saved the day. I've merged his changes locally and although there is one minor issue (the lower 'loadMore' chunk not being triggered perfectly at the boundary) it seems pretty nice. I will probably squash and open a first PR for review.

Comment 6

[Jonathan French (:jfrench)]

I spoke too soon. A bunch more flow and clipping problems introduced with those changes.

Comment 7

[Jonathan French (:jfrench)]

I spoke with jeads on IRC and we decided we'll wait till camd is back next week for better context on his approach. If anyone wants to pursue it before that, just ping me.

Comment 8

[Jonathan French (:jfrench)]

I spoke with camd on IRC and I'm going to push camd's work with some very minor tweaks and open a PR shortly for review. Successful steps on passed jobs will be clipped slightly at extremely narrow browser dimensions, but other than that all the functionality is there and it addresses the initial user problem.

Comment 9

[Jonathan French (:jfrench)]

Attachment: treeherder-ui-PR#131

Please see the above PR for review and status.

Comment 10

[Jonathan French (:jfrench)]

Appears to be fixed and working correctly on dev. Marking fixed prior to push to stage/prod.

There are a couple of minor log scroll issues w.r.t. failed steps, but I don't think they are related to this change. I will open them as separate non-blockers if applicable.

Comment 11

[Ed Morley [:emorley]]

Looks good on dev thank you :-)