104247 - buglist.cgi colorization is broken

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Christian Reis]

This is a stopgap, but the fact that broken code is checked in should be fixed.
I know this will be impacted by bug 69654 but that doesn't look like it's going
to be implemented before templates and HTML compliancy, so let's fix this first.

Comment 1

[Christian Reis]

Attachment: kiko_v1: fix typos to activate colouring

Comment 2

[Christian Reis]

Gerv, what's your opinion? See this in action:

http://bugs.async.com.br/buglist.cgi

Comment 3

[Gervase Markham [:gerv]]

Love it. Attach the patch and I'll review it.

Gerv

Comment 4

[Christian Reis]

Uhh, Gerv, it's attached.

Comment 5

[Gervase Markham [:gerv]]

Comment on attachment 53131 [details] [diff] [review]
kiko_v1: fix typos to activate colouring

r=gerv.

Doh. This doesn't require second review.

Gerv

Comment 6

[Gervase Markham [:gerv]]

/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.146; previous revision: 1.145

Gerv

Comment 7

[GavinS]

*** Bug 92911 has been marked as a duplicate of this bug. ***

Comment 8

[Dave Miller [:justdave]]

Fixed for 2.16

Comment 9

[Dave Miller [:justdave]]

no, really this time :)

Comment 10

[Jesse Ruderman]

See also bug 36013, use colors for each severity.

Comment 11

[Peter Trudelle]

How do I turn this off in my bug lists?

Comment 12

[Gervase Markham [:gerv]]

You can do it with a user stylesheet, I suppose. userContent.css in your chrome
directory - add style rules to set the colour to black for the classes we use to
tag the rows.

Gerv

Comment 13

[Bradley Baetz (:bbaetz)]

but we don't use classes in all places - the red is done with !important style
tags, in some cases with invalid syntax too

Comment 14

[Peter Trudelle]

Excuse me, but why put the burden on me to write code to turn off this unwanted
feature?  Are all users supposed to write their own CSS just to get *no* style?
That's backwards. I have no idea how to do it, and think it is wrong to require
it.  If some users want to see different styles, requiring *them* to add style
rules would make sense.

Comment 15

[Matthew Tuck [:CodeMachine]]

We could make this an external author stylesheet I suppose.

Comment 16

[Gervase Markham [:gerv]]

> Excuse me, but why put the burden on me to write code to turn off this unwanted
> feature?

This seems the wrong way round. If it were not possible to change something
about Bugzilla you don't like (for example, if you believe the header on bug
views is a waste of space, as I do, or you wanted comments in a proportional
font), you would just live with it. Because Mozilla is powerful enough to let
you alter this behaviour, you are suddenly annoyed?

We might be able to make this a user option; but there would need to be evidence
that more people cared enough to want to customise it.

Gerv

Comment 17

[Peter Trudelle]

Having to write a style sheet to get normal UN-styled text seems the wrong way
around.  Making this change should have required user-centered designers to
determine if enough people would actually benefit by it, which is vastly
different from a few people saying they wanted it.  I'm suddenly annoyed because
one of the primary tools that I depend on to do my job, for several hours every
day, has suddenly made my job more difficult.