Closed
Bug 1042580
Opened 10 years ago
Closed 10 years ago
[Contacts][ICE] Create additional panel in Contacts Settings
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S1 (1aug)
People
(Reporter: mbudzynski, Assigned: mbudzynski)
References
Details
Attachments
(1 file)
We need new button for ICE Contacts support in settings view of the Contacts App.
Assignee | ||
Updated•10 years ago
|
Target Milestone: --- → 2.1 S1 (1aug)
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
WIP patch I prepared already has all the HTML needed in the ICE view, I'm working now on the logic.
Assignee | ||
Comment 3•10 years ago
|
||
L10N + locales for ICE view https://github.com/michalbe/gaia/commit/a348f3395ab8be2e824920fd4183d71cee90cb37
Assignee | ||
Comment 4•10 years ago
|
||
Patch ready for r.
Assignee | ||
Updated•10 years ago
|
Attachment #8460943 -
Attachment description: WORK IN PROGRESS PATCH → final patch
Attachment #8460943 -
Flags: review?(francisco)
Assignee | ||
Comment 5•10 years ago
|
||
When I'll get r+ from :arcturus, `button#set-ice` will be hidden before landing.
Comment 6•10 years ago
|
||
Comment on attachment 8460943 [details] [review] final patch Hei Michal! Excellent patch, just got an idea, instead of putting everything in settings.js, I think we should create all ICE functionality in a ice.js that is loaded from settings as a dependency via lazyloader. Then we call something like ice.init, and this takes the references and add the listeners and all that stuff. With that, we can isolate all functionality related to ICE in the ice.js also, when we move to haida, we can use this file in the document holding this functionality instead of having to load settings. What do you think?
Attachment #8460943 -
Flags: review?(francisco)
Assignee | ||
Comment 7•10 years ago
|
||
I think it's an excellent idea, like most of yours :). I'm on it now.
Assignee | ||
Comment 8•10 years ago
|
||
Comment on attachment 8460943 [details] [review] final patch Does it fit your requirements now, sir?
Attachment #8460943 -
Flags: review?(francisco)
Comment 9•10 years ago
|
||
Comment on attachment 8460943 [details] [review] final patch Left a couple of comments. One simple nit, and a suggestion to add one unit test to check the navigation to the new screen. Once we have that and gaia-try is green please go ahead! Thanks!
Attachment #8460943 -
Flags: review?(francisco) → review+
Assignee | ||
Comment 10•10 years ago
|
||
Comment on attachment 8460943 [details] [review] final patch indentation fixed, tests added. Francisco, pls gimme feedback on those last changes
Attachment #8460943 -
Flags: feedback?(francisco)
Comment 11•10 years ago
|
||
Comment on attachment 8460943 [details] [review] final patch Thanks Michal!
Attachment #8460943 -
Flags: feedback?(francisco) → feedback+
Assignee | ||
Comment 12•10 years ago
|
||
Thanks, landed: https://github.com/michalbe/gaia/commit/16611a5b934fff05e586a4ec5e7be9da2935b8b1
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•