Closed Bug 1042584 Opened 10 years ago Closed 9 years ago
[Contacts][ICE] Select the contact from the list
We need to be able to choose which contact we want to add to the ICE group. This should use similar view as 'update' activity when we want to add a phone number to the given contact from the Dialer App.
Target Milestone: 2.1 S1 (1aug) → 2.1 S2 (15aug)
blocking-b2g: --- → backlog
feature-b2g: --- → 2.1
Target Milestone: 2.1 S2 (15aug) → 2.1 S3 (29aug)
I'm actively working on this patch, work in progress commit is prepared here . It introduces selecting contact from contacts list, so the parts that are missing is internal storage for chosen ICE contacts and managing which of them should be exposed in datastore. I should finish it today/tomorrow.  https://github.com/michalbe/gaia/commit/925c08e060376e9c681f249afd415320e859e2c2
This feature has already been covered in the meta bug: bug 1026682 comment 2.
Flags: in-moztrap?(jlorenzo) → in-moztrap+
Stealing for landing before this friday ;)
Assignee: mbudzynski → francisco
Adrian, this is a WIP based on Michal work. Could you take a look, and modify whatever you consider necessary? Right now is working but I applied last modifications pretty fast and would like a second opinion before landing this. Will you take a look for improvements?
I've made some comments on GitHub about this pull request. I also saw that there is no way to cancel the selection of an ICE contact. Once the selector is opened the user has to choose a contact and then deactivate that ICE contact to cancel the selection. And if the user goes back to the homescreen, when they return to the contacts app they see the usual list but the click handler has been changed to add the selected contact as ICE contact. I think there is a way in contacts to launch a selector with a title and a cancel button, which I think it would be more user friendly.
Flags: needinfo?(hola) → needinfo?(francisco)
Comment on attachment 8479201 [details] [review] Patch for PR 23326 Hei, ready for review!
Attachment #8479201 - Flags: review?(sergi.mansilla)
Comment on attachment 8479201 [details] [review] Patch for PR 23326 Hei Alberto, would you mind giving feedback before we get the final review?
Attachment #8479201 - Flags: feedback?(apastor) → feedback+
Comment on attachment 8479201 [details] [review] Patch for PR 23326 Good job francisco!
Attachment #8479201 - Flags: review?(sergi.mansilla) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Verified User story is fixed. ICE can be set, view in Contacts, couple bugs found. Gaia 2be78d83a760fa3b9638fe51c266b442d14597f1 Gecko https://hg.mozilla.org/mozilla-central/rev/1db35d2c9a2f BuildID 20140831160203 Version 34.0a1 ro.build.version.incremental=110 ro.build.date=Fri Jun 27 15:57:58 CST 2014 B1TC00011230 1061072 [Contacts] Back 'X' is missing from Set ICE page (Single select mode) 1061069 [Contacts] ICE icon on top of the contact list is truncated 1061068 [Contacts] ICE missing from top of the list when toggling the 'Order by last name'
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.