1042584 - [Contacts][ICE] Select the contact from the list

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Michał Budzyński (:michalbe)]

We need to be able to choose which contact we want to add to the ICE group. This should use similar view as 'update' activity when we want to add a phone number to the given contact from the Dialer App.

Comment 1

[Michał Budzyński (:michalbe)]

I'm actively working on this patch, work in progress commit is prepared here [1]. It introduces selecting contact from contacts list, so the parts that are missing is internal storage for chosen ICE contacts and managing which of them should be exposed in datastore. I should finish it today/tomorrow.

[1] https://github.com/michalbe/gaia/commit/925c08e060376e9c681f249afd415320e859e2c2

Comment 2

[Johan Lorenzo [:jlorenzo]]

This feature has already been covered in the meta bug: bug 1026682 comment 2.

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Stealing for landing before this friday ;)

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Patch for PR 23326

Adrian, this is a WIP based on Michal work.

Could you take a look, and modify whatever you consider necessary? Right now is working but I applied last modifications pretty fast and would like a second opinion before landing this.

Will you take a look for improvements?

Comment 5

[Adrián de la Rosa]

I've made some comments on GitHub about this pull request.

I also saw that there is no way to cancel the selection of an ICE contact. Once the selector is opened the user has to choose a contact and then deactivate that ICE contact to cancel the selection. And if the user goes back to the homescreen, when they return to the contacts app they see the usual list but the click handler has been changed to add the selected contact as ICE contact. I think there is a way in contacts to launch a selector with a title and a cancel button, which I think it would be more user friendly.

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8479201 [details] [review]
Patch for PR 23326

Hei,

ready for review!

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8479201 [details] [review]
Patch for PR 23326

Hei Alberto,

would you mind giving feedback before we get the final review?

Comment 8

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Comment on attachment 8479201 [details] [review]
Patch for PR 23326

Good job francisco!

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/56c76ddb7ecad51794ef2c2db1be7cd72be27d02

\o/

Comment 10

[Eric Chang [:ericcc] [:echang]]

Verified User story is fixed. ICE can be set, view in Contacts, couple bugs found.

Gaia      2be78d83a760fa3b9638fe51c266b442d14597f1
Gecko     https://hg.mozilla.org/mozilla-central/rev/1db35d2c9a2f
BuildID   20140831160203
Version   34.0a1
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230

1061072 [Contacts] Back 'X' is missing from Set ICE page (Single select mode) 
1061069 [Contacts] ICE icon on top of the contact list is truncated
1061068 [Contacts] ICE missing from top of the list when toggling the 'Order by last name'