Closed Bug 1042618 Opened 11 years ago Closed 8 years ago

[Keyboard][v2.0] Some unit tests are failing in keyboard

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: mukeshk1990, Unassigned)

References

Details

(Whiteboard: [LibGLA,dev,C])

[Title]: [Keyboard][v2.0] Some unit tests are failing in keyboard Following are the errors which are causing unit test to fail. [keyboard-test/unit/render_test.js] Key with ratio 2 should be twice as big ‣ Error: Error: expected 773 to equal 772 (http://keyboard.gaiamobile.org:8080/common/test/helper.js?time=1406022768001:31) at onerror (http://keyboard.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4959:10) [keyboard-test/unit/render_test.js] getHeight, 2 rows, portrait, suggest, latin Error: Error: expected 55 to equal 56 (http://keyboard.gaiamobile.org:8080/common/test/helper.js?time=1406022768001:31) at onerror (http://keyboard.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4959:10)
Flags: needinfo?(rlu)
Whiteboard: [LibGLA,dev,C]
May I know your environment to run these unit tests? on Mac or Linux and you're using Firefox browser Nightly? This looks similar to bug 1023197, but I've started to dig into this issue.
Flags: needinfo?(rlu)
See Also: → 1023197
(In reply to Rudy Lu [:rudyl] from comment #1) > May I know your environment to run these unit tests? > on Mac or Linux and you're using Firefox browser Nightly? > > This looks similar to bug 1023197, but I've started to dig into this issue. ^ not Sorry for the misleading info.
I am running this unit test in Linux Ubuntu 12.04 environment and firefox Nightly version 31.
(In reply to Mukesh kumar from comment #3) > firefox Nightly version 31. Sorry for the wrong info. I am executing these test in firefox Nightly version 33.0a1.
Jan, Not sure if you have bandwidth to look into unit test related issues like this one and bug 1023197, please help if you can, since I would focus on v2.1 feature first.
Flags: needinfo?(janjongboom)
These are rounding bugs, just run the tests with the responsive view on, and on a 320x480 resolution. Or we can fix it by allowing 1px difference (which we did in other tests), but as long as it passes on Travis I don't really care.
Flags: needinfo?(janjongboom)
Firefox OS is not being worked on
Status: UNCONFIRMED → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.