1042634 - Incorrect NULL check in function CRMF_CertReqMsgGetPOPKeyEncipherment (servget.c)

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Sachin Kumar Gupta]

Attachment: Patch for the above raised bug

In the file nss/lib/crmf/servget.c, the function CRMF_CertReqMsgGetPOPKeyEncipherment performs an incorrect NULL check. 


*destKey is being allocated memory, but null check is being performed on destKey. It should be performed on *destKey instead.


3.16.3 version code:

*destKey = PORT_ZNew(CRMFPOPOPrivKey);
    if (destKey == NULL) {
       return SECFailure;
    }


Should be:

*destKey = PORT_ZNew(CRMFPOPOPrivKey);
    if (*destKey == NULL) {
        return SECFailure;
    }

Comment 1

[Nathan Yee [:nyee]]

Reminder for someone to check the bug and proposed patch.

Comment 2

[Nathan Yee [:nyee]]

(In reply to Nathan Yee [:nyee] from comment #1)
> Reminder for someone to check the bug and proposed patch.

Comment 3

[Nathan Yee [:nyee]]

(In reply to Nathan Yee [:nyee] from comment #1)
> Reminder for someone to check the bug and proposed patch.

Comment 4

[Robert Relyea]

Comment on attachment 8460838 [details] [diff] [review]
Patch for the above raised bug

Review of attachment 8460838 [details] [diff] [review]:
-----------------------------------------------------------------

r+ rrelyea

Comment 5

[Kai Engert (:KaiE:)]

https://hg.mozilla.org/projects/nss/rev/791617b5572a