Marionette constructor should accept a single **runner_args variable

RESOLVED INCOMPLETE

Status

Testing
Marionette
RESOLVED INCOMPLETE
4 years ago
2 years ago

People

(Reporter: ahal, Unassigned)

Tracking

({ateam-marionette-client})

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

4 years ago
Right now the marionette constructor accepts a ton of different parameters to its constructor that are then immediately passed on to mozrunner and are not used in any other place.

In addition to adding lots of clutter, this means anytime the mozrunner signature changes, marionette also needs to be updated. Also half the parameters only work with a particular mozrunner class (e.g B2GEmulatorRunner) which makes it very confusing to figure out how to properly use them all.

I think we should only define the core marionette arguments, and then automatically pass through any unrecognized arguments to mozrunner (and let mozrunner raise an error if there is something invalid). We can do this without breaking backwards compatibility.
Keywords: ateam-marionette-client
We have cleaned up the constructor in bug 1274408 a lot and will be doing more in other bugs. Not sure I agree with using **runner_args but agree with the sentiment. 

Closing this bug as we are doing the clean up in other bugs
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.