Closed Bug 1042687 Opened 10 years ago Closed 10 years ago

[e10s] all words marked misspelled initially

Categories

(Core :: Spelling checker, defect)

Product:
Core
Component:
Spelling checker
Version:
34 Branch
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Iteration:
35.2
Tracking Flags:
Tracking Status
e10s m6+ ---

People

(Reporter: samth, Assigned: ally)

References

Details

It's hard for me to precisely tell what happened, but I think that for a while, any words typed in a text area in my e10s-enabled FF Nightly were marked as misspelled. This then changed to work correctly -- for example, the Twitter "Compose new tweet" default text was marked as misspelled, then when I clicked on it and clicked away, the default text reappeared but was now not red-underlined.

I expect there's some initialization issue here, but I can't really tell.
This happens reproducibly when I restart the browser.

For example, I just restarted FF, and it's now marking all of the words that I'm typing right now as misspelled.
tracking-e10s: --- → ?
Couldn't reproduce, 34.0a1 (2014-07-24), Win 7 x64.
Please check if the issue occurs using Firefox in safe mode (with your addons disabled):
http://support.mozilla.com/kb/Safe+Mode

And on a new, empty profile:
http://support.mozilla.org/en-US/kb/Managing-profiles#w_starting-the-profile-manager
This is reproducible for me both in safe mode and with a new empty profile.
Status: UNCONFIRMED → NEW
Ever confirmed: true
I can't reproduce.  Sam, can you tell use more about your configuration? 

Is this with browser.tabs.remote.autostart = true or are you using the e10s window?

Safe mode is known to have problems, bug 1026521.
Assignee: nobody → ally
This is with remote.autostart = true (e10s windows won't work for me on Linux).

More on my config:
 - Ubuntu 14.04.1
 - Nightly from https://launchpad.net/~ubuntu-mozilla-daily/+archive/ubuntu/ppa
 - currently Nightly from 7/23

I have a bunch of addons, but it happens in a fresh profile without them as well.

:ally, note that it only happens on initial start of E10S Nightly -- after a few minutes, it starts working correctly.
(In reply to Sam Tobin-Hochstadt [:samth] from comment #5)
> :ally, note that it only happens on initial start of E10S Nightly -- after a
> few minutes, it starts working correctly.

And before you give the editable window focus?
Also, how old is your machine? I suspect the ipc is taking too long to get set up the first time.
(In reply to :ally Allison Naaktgeboren from comment #6)
> (In reply to Sam Tobin-Hochstadt [:samth] from comment #5)
> > :ally, note that it only happens on initial start of E10S Nightly -- after a
> > few minutes, it starts working correctly.
> 
> And before you give the editable window focus?

No, it continues after -- comment #5 was typed in E10S and all marked misspelled as I typed it.
(In reply to :ally Allison Naaktgeboren from comment #7)
> Also, how old is your machine? I suspect the ipc is taking too long to get
> set up the first time.

My machine is very very fast (8 core i7). 

This might be related to 1042675 which also went away after a while.
(In reply to Sam Tobin-Hochstadt [:samth] from comment #9)
> My machine is very very fast (8 core i7). 

Whelp, there goes that theory. And you're using the default/included English dictionary? 

If you have a local build, try changing http://mxr.mozilla.org/mozilla-central/source/extensions/spellcheck/hunspell/src/RemoteSpellCheckEngineParent.cpp#37 to true. 

Since I can not reproduce but you can, we'll have to resort to guess-n-check.
Flags: needinfo?(samth)
I don't have a local build. Should I make one?
Flags: needinfo?(samth)
Please, that would be very helpful.
After building myself, the first result is that I can't reproduce on that build. I'll see if I can provoke it in another way.
r-rhoh
Any luck reproducing? I've rolled the change into default values into the patch for Bug 1030451
Flags: needinfo?(samth)
I set the default isCorrect value to true when I landed the patch for Bug 1030451. Once it merges to m-c (Nightly), I'd also like to know if you are seeing this problem in the original Nightly as well.

    
    

    
  
Sam? poke, poke?

    
    

    
  
Hey, sorry, was away for a while. What date of Nightly will the patch for 1030451 be in?

    
    

    
  
It should be in today''s Nightly. It merged to m-c yesterday.

landed in central : https://hg.mozilla.org/mozilla-central/rev/9ea4953de5b3

    
    

    
  
Ok, sorry for the delay. Here's the current status.

1. This bug is still happening in the Nightly I'm typing this in (everything is marked misspelled) -- this is Nightly from 8/4 though.
2. I just rebuilt m-c and didn't see the problem in a quick test.

This makes me think that the problem is that my regular session opens a large number of tabs initially, which is the main difference between the two cases.

I'll see if I can get a reproduction recipe that way.
Flags: needinfo?(samth)

    
    

    
  
Ok, sadly that didn't work. Any other suggestions?

    
    

    
  
Can you grab a fresh copy of nightly? 8/4 Nightly doesn't have my patch so I'd expect the behavior to reproduce there. 8/13-14 is the Nightly I'd like you to test.

I average a 100 or so tabs. How many tabs do you have in that profile on average?

    
    

    
  
I've grabbed a fresh nightly, but I can't seem start it on my pre-existing profile, and thus can't restore my tabs.

I have about 30 tabs in 3 tab groups.

    
    

    
  
Is your profile open in another firefox? Profiles aren't multiprocess, and can only be opened in one firefox at a time.

How about on a fresh profile? Do you see the nasty old behavior there?

    
    

    
  
Ok, I finally figured out how to run my normal profile successfully in a build from 8/14, and that didn't reproduce the bug. Once the Ubuntu PPA updates paste 8/14, I'll re-update this bug as to whether it still appears then.

    
    

    
  
Thanks. You rock.

    
    

    
  
When will Ubuntu ppa update past 8/14? If they're supporting the nightly channel, I'd imagine they've updated by now...
Flags: needinfo?(samth)

    
    

    
  
Sadly not -- the latest build here https://launchpad.net/~ubuntu-mozilla-daily/+archive/ubuntu/ppa is still 8/4.
Flags: needinfo?(samth)

    
    

    
  
for serious?! ugh

    
  
Status: NEW → ASSIGNED

    
    

    
  
maybe its updated since its a new month?
Flags: firefox-backlog+
Flags: firefox-backlog+
Flags: firefox-backlog+

    
    

    
  
has ubuntu updated nightly yet so we can finally put this thing to bed?
Flags: needinfo?(samth)

    
    

    
  
Sadly, no. Is there an easy way to get a Mozilla-distributed Nightly to use my existing profile?
Flags: needinfo?(samth)

    
    

    
  
Move old M2's low-priority bugs to M6 milestone.

          tracking-e10s:
          + → m6+
See Also:  → 1068150

    
    

    
  
(In reply to Sam Tobin-Hochstadt [:samth] from comment #33)
> Sadly, no. Is there an easy way to get a Mozilla-distributed Nightly to use
> my existing profile?

You want the profile manager https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles  which will let you do just that :)
Flags: needinfo?(samth)

    
    

    
  
This seems to be fixed now that Ubuntu (finally) upgraded Nightly. Yay!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: needinfo?(samth)
Resolution: --- → FIXED
Iteration: --- → 35.2
Flags: qe-verify?

    
  
Flags: qe-verify? → qe-verify+
QA Contact: jbecerra

          You need to log in
          before you can comment on or make changes to this bug.