onResponse is not a function at dbg-client.jsm:1670

RESOLVED FIXED in Firefox 34

Status

P2
normal
RESOLVED FIXED
4 years ago
4 months ago

People

(Reporter: past, Assigned: past)

Tracking

unspecified
Firefox 34

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

STR:

1. Open the debugger in http://todomvc.com/architecture-examples/backbone/
2. Open the events pane and choose to break on click events.
3. Click in the input box and then clear the break-on-click checkbox.
4. The Browser Console contains the error: onResponse is not a function at dbg-client.jsm:1670

Patch forthcoming.
Priority: -- → P2
Created attachment 8460968 [details] [diff] [review]
Ensure that the debugger client doesn't try to call a callback, when one is not provided

Fortunately this bug doesn't break anything for me, because the error is thrown in a setTimeout call, so the event loop is empty. I've looked around in the debugger client and there are a number of other cases where we assume the caller will supply a callback that I also fixed.
Attachment #8460968 - Flags: review?(rcampbell)
Rather than repeating `() => {}` everywhere, can we just define `const noop = () => {};` and use that?
Created attachment 8460978 [details] [diff] [review]
Ensure that the debugger client doesn't try to call a callback, when one is not provided v2

Good idea, but used let instead of const, because there was a redeclaration error that I didn't want to figth with.
Attachment #8460978 - Flags: review?(rcampbell)
Attachment #8460968 - Attachment is obsolete: true
Attachment #8460968 - Flags: review?(rcampbell)
Attachment #8460978 - Flags: review?(rcampbell) → review+
https://hg.mozilla.org/mozilla-central/rev/01d60712d7a4
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
QA Whiteboard: [qa-]
QA Whiteboard: [qa-] → [good first verify]
Panos Astithas, could you please add another test page? The one from comment 0 seems to not be available. Thank you
Flags: needinfo?(past)
It seems to be moved here:
http://todomvc.com/examples/backbone/
Flags: needinfo?(past)

Updated

4 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.