Closed Bug 1042765 Opened 6 years ago Closed 6 years ago

Better logging for GMP plugins

Categories

(Core :: Plug-ins, defect)

x86_64
All
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34
Tracking Status
firefox33 --- fixed
firefox34 --- fixed

People

(Reporter: jesup, Assigned: jesup)

Details

Attachments

(1 file, 2 obsolete files)

Right now there's effectively no logging in the GMPService
QA Contact: drno
Attachment #8460955 - Flags: review?(cpearce)
Attachment #8460955 - Attachment is obsolete: true
Attachment #8460955 - Flags: review?(cpearce)
unbitrotted; applies on updated bug 1041232
Attachment #8461793 - Attachment is obsolete: true
Attachment #8462030 - Flags: review?(cpearce)
Comment on attachment 8462030 [details] [diff] [review]
Better logging for GMP plugins

Review of attachment 8462030 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/webrtc/signaling/src/media-conduit/WebrtcGmpVideoCodec.cpp
@@ +300,5 @@
>  
>  int32_t
>  WebrtcGmpVideoEncoder::Release()
>  {
> +  LOGD(("GMP Released:"));

I think the PRLogModuleInfo should live in content/media/gmp, since it's used in 4 files there a lot more than it's used in WebrtcGmpVideoCodec.cpp, and the build will break in content/media/gmp if webrtc is disabled. Can you either move it before landing to prevent dholbert complaining?
Attachment #8462030 - Flags: review?(cpearce) → review+
https://hg.mozilla.org/mozilla-central/rev/37b3cad03b99
Assignee: nobody → rjesup
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Comment on attachment 8462030 [details] [diff] [review]
Better logging for GMP plugins

Approval Request Comment
[Feature/regressing bug #]: openh264

[User impact if declined]: only on developers: many more conflicts merging, more chance of mis-merge, debugging any 33-specific problem becomes harder.  This is optional.

[Describe test coverage new/current, TBPL]: N/A

[Risks and why]: Low/very-low risk - debugging code is Debug-only (not forced into opt builds).  And the code in this case is entirely log messages (not variant code to generate data for logs).  Primary risk would be mistakes in merging this

[String/UUID change made/needed]: none
Attachment #8462030 - Flags: approval-mozilla-aurora?
Attachment #8462030 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.