1042765 - Better logging for GMP plugins

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

Right now there's effectively no logging in the GMPService

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Better logging for GMP plugins

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Better logging for GMP plugins

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Better logging for GMP plugins

unbitrotted; applies on updated bug 1041232

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8462030 [details] [diff] [review]
Better logging for GMP plugins

Review of attachment 8462030 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/webrtc/signaling/src/media-conduit/WebrtcGmpVideoCodec.cpp
@@ +300,5 @@
>  
>  int32_t
>  WebrtcGmpVideoEncoder::Release()
>  {
> +  LOGD(("GMP Released:"));

I think the PRLogModuleInfo should live in content/media/gmp, since it's used in 4 files there a lot more than it's used in WebrtcGmpVideoCodec.cpp, and the build will break in content/media/gmp if webrtc is disabled. Can you either move it before landing to prevent dholbert complaining?

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/37b3cad03b99

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/37b3cad03b99

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8462030 [details] [diff] [review]
Better logging for GMP plugins

Approval Request Comment
[Feature/regressing bug #]: openh264

[User impact if declined]: only on developers: many more conflicts merging, more chance of mis-merge, debugging any 33-specific problem becomes harder.  This is optional.

[Describe test coverage new/current, TBPL]: N/A

[Risks and why]: Low/very-low risk - debugging code is Debug-only (not forced into opt builds).  And the code in this case is entirely log messages (not variant code to generate data for logs).  Primary risk would be mistakes in merging this

[String/UUID change made/needed]: none

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/126d41d598be