Better logging for GMP plugins

RESOLVED FIXED in Firefox 33

Status

()

Core
Plug-ins
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jesup, Assigned: jesup)

Tracking

unspecified
mozilla34
x86_64
All
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox33 fixed, firefox34 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

3 years ago
Right now there's effectively no logging in the GMPService
(Assignee)

Comment 1

3 years ago
Created attachment 8460955 [details] [diff] [review]
Better logging for GMP plugins
QA Contact: drno
(Assignee)

Updated

3 years ago
Attachment #8460955 - Flags: review?(cpearce)
(Assignee)

Comment 2

3 years ago
Created attachment 8461793 [details] [diff] [review]
Better logging for GMP plugins
(Assignee)

Updated

3 years ago
Attachment #8460955 - Attachment is obsolete: true
Attachment #8460955 - Flags: review?(cpearce)
(Assignee)

Comment 3

3 years ago
Created attachment 8462030 [details] [diff] [review]
Better logging for GMP plugins

unbitrotted; applies on updated bug 1041232
(Assignee)

Updated

3 years ago
Attachment #8461793 - Attachment is obsolete: true
(Assignee)

Updated

3 years ago
Attachment #8462030 - Flags: review?(cpearce)
Comment on attachment 8462030 [details] [diff] [review]
Better logging for GMP plugins

Review of attachment 8462030 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/webrtc/signaling/src/media-conduit/WebrtcGmpVideoCodec.cpp
@@ +300,5 @@
>  
>  int32_t
>  WebrtcGmpVideoEncoder::Release()
>  {
> +  LOGD(("GMP Released:"));

I think the PRLogModuleInfo should live in content/media/gmp, since it's used in 4 files there a lot more than it's used in WebrtcGmpVideoCodec.cpp, and the build will break in content/media/gmp if webrtc is disabled. Can you either move it before landing to prevent dholbert complaining?
Attachment #8462030 - Flags: review?(cpearce) → review+
(Assignee)

Comment 5

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/37b3cad03b99
Target Milestone: --- → mozilla34
https://hg.mozilla.org/mozilla-central/rev/37b3cad03b99
Assignee: nobody → rjesup
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Comment 7

3 years ago
Comment on attachment 8462030 [details] [diff] [review]
Better logging for GMP plugins

Approval Request Comment
[Feature/regressing bug #]: openh264

[User impact if declined]: only on developers: many more conflicts merging, more chance of mis-merge, debugging any 33-specific problem becomes harder.  This is optional.

[Describe test coverage new/current, TBPL]: N/A

[Risks and why]: Low/very-low risk - debugging code is Debug-only (not forced into opt builds).  And the code in this case is entirely log messages (not variant code to generate data for logs).  Primary risk would be mistakes in merging this

[String/UUID change made/needed]: none
Attachment #8462030 - Flags: approval-mozilla-aurora?
status-firefox33: --- → affected
status-firefox34: --- → fixed
Attachment #8462030 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 8

3 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/126d41d598be
status-firefox33: affected → fixed
Whiteboard: [openh264-uplift]
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.