1042769 - Add automated test for checking that the metainfo fields are displayed in password manager

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect)

Description

[Mihaela Velimiroviciu (:mihaelav)]

Add automated test for the following test:
https://moztrap.mozilla.org/manage/cases/?filter-id=13720#caseversion-id-136077

Steps: 
1. Launch Firefox.
2. Access a website that provides a login form.
3. Type in your username and password then press the login button.
4. Click "Remember Password" from the doorhanger.
5. From the menu panel, click Options, then choose "Security" from the side menu.
6. From the "Security" page, click on the "Saved Passwords..." button.

Expected result:
The website you saved your password for is displayed in the "Site" column, along with the associated data underneath "Username", "Last Used" and "Last Changed" columns.

Comment 1

[Mihaela Velimiroviciu (:mihaelav)]

Attachment: v1

The test

Comment 2

[:Paolo Amadini]

Comment on attachment 8462438 [details] [diff] [review]
v1

Review of attachment 8462438 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this! I made a first pass review, feel free to re-request feedback from me on the next version and I'll request final review from Matthew when ready.

::: toolkit/components/passwordmgr/test/browser/browser_passwordmgr_fields.js
@@ +35,5 @@
> +         "Last Used column is displayed");
> +
> +      let timePasswordChangedCol = doc.getElementById("timePasswordChangedCol");
> +      is(timePasswordChangedCol.getAttribute("hidden"), "",
> +         "Last Changed column is displayed");

I believe you need to add the checks for the actual data in the first row.

@@ +40,5 @@
> +
> +      // cleanup
> +      Services.ww.registerNotification(function (aSubject, aTopic, aData) {
> +        // unregister ourself
> +        Services.ww.unregisterNotification(arguments.callee);

To avoid intermittent failures, you should check that the parameters match the window for which you are expecting the notification.

@@ +49,5 @@
> +      });
> +      pwmgrdlg.close();
> +    }
> +
> +    checkColumns();

Since you call this once, the function is unneeded.

Comment 3

[Mihaela Velimiroviciu (:mihaelav)]

Attachment: v2

Comment 4

[:Paolo Amadini]

Comment on attachment 8464003 [details] [diff] [review]
v2

Looks good to me! Flagging MattN for final review.

Note that this doesn't fully replace the moztrap test from comment 0, because the interaction with the doorhanger is not part of the automated test, but is still a good improvement to our code coverage!

Comment 5

[Mihaela Velimiroviciu (:mihaelav)]

Try run is green: https://tbpl.mozilla.org/?tree=Try&rev=abe3892a3f24

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/064789f0d387

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/064789f0d387