1042797 - Remove double confirmation for uninstalling apps

Status: VERIFIED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Ted Clancy [:tedders1]]

Since the system will prompt users to confirm requests to uninstall apps, it's not necessary for |verticalhome| to show a confirmation prompt as well.

Furthermore, the system's confirmation prompt should resemble |verticalhome|'s (former) prompt, since that prompt was reviewed by UX. 

Note that there are currently two different prompts depending on whether the app was successfully installed or not. We can choose the appropriate prompt based on the app's status.

+++ This bug was initially created as a clone of Bug #899994 +++

Comment 1

[Ted Clancy [:tedders1]]

Attachment: Prompting of uninstall now done by system app. Remove other prompts.

This patch:
* Adds prompting to the system app
* Removes prompting from the settings app
* Removes prompting from the vertical homescreen app

Putting this all in one place made the patch easier to understand. I'll remove the duplicate changes from 1000315.

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8468075 [details] [review]
Prompting of uninstall now done by system app. Remove other prompts.

I'll want to see a green test run before R+ing, and it currently looks like linters are failing, so please fix that and re-flag me.

One thing to note is that this will probably break the tablet UI as that still uses the old homescreen. I am fine following-up with another bug to fix tablet though.

You will also probably need to get a system/settings peer to review as well, maybe Tim or Alive. Thanks so much for doing this, it's starting to look great!

Comment 3

[Ted Clancy [:tedders1]]

I could have sworn I had a green test run for this somewhere... let me kick off a new one now.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8468075 [details] [review]
Prompting of uninstall now done by system app. Remove other prompts.

r+ assuming this is the right UX we want.

Gij is still failing but it might not be related and you need to rebase.

Comment 5

[Ted Clancy [:tedders1]]

This needs to be landed at the same time as 1000315.

Here's a successful TBPL run: https://tbpl.mozilla.org/?tree=Try&rev=fec76c5af66c

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/169a465e71138b892799b8a8f188eaf7d1bf06d0

Comment 7

[Lance（leave from Mozilla）]

This issue has been verified successfully on Flame 2.1.
See attachment: 1518.MP4
Reproducing rate: 0/5

Step:
1.Launch Marketplace.
2.Install some app.
3.Return to home screen.
4.Long press Marketplace installed app.
5.Tap red "x" to bring up deletion menu.
6.Tap "Delete" button.

Actual result:
6.The uninstall app prompt box only pops up for once.
7.The app uninstall successfully.

Comment 8

[Lance（leave from Mozilla）]

Attachment: 1518.MP4