Pressing undo twice after loading a file clears out the content

VERIFIED FIXED in Firefox 34

Status

()

Firefox
Developer Tools: WebIDE
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: bgrins, Assigned: bgrins)

Tracking

Trunk
Firefox 34
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
STR:
1) Open a file in the project editor (say, styles.css here: chrome://browser/content/devtools/projecteditor-loader.xul)
2) Undo twice

Expected
Nothing happens when undoing (the file just loaded and you haven't made any changes)

Actual
The contents of the editor is cleared out

There is a clearHistory provided by the Editor object, so it may just be as simple as calling that after calling setText in editor.load
(Assignee)

Comment 1

3 years ago
Created attachment 8469254 [details] [diff] [review]
undo-clear.patch

This fixes the issue
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Attachment #8469254 - Flags: review?(jryans)
Comment on attachment 8469254 [details] [diff] [review]
undo-clear.patch

Review of attachment 8469254 [details] [diff] [review]:
-----------------------------------------------------------------

Seems to work well!  Thanks!
Attachment #8469254 - Flags: review?(jryans) → review+
(Assignee)

Comment 3

3 years ago
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=73788c21213b
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/2ead24c96a8e
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/2ead24c96a8e
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 34
QA Whiteboard: [qa+]
Verified as fixed using latest Aurora 34.0a2 build (20141008004004) under Win 7 64-bit, Ubuntu 13.04 64-bit and Mac OSX 10.9.5. Undo is active only after modifying file's content.
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa+] → [qa!]
You need to log in before you can comment on or make changes to this bug.