[Loop][Visual] Implement call screen visuals

RESOLVED FIXED

Status

Firefox OS
Gaia::Loop
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: borjasalguero, Assigned: borjasalguero)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

60 bytes, text/x-github-pull-request
jaoo
: review+
On parental leave
: review+
vicky
: ui-review+
arnau
: feedback+
Details | Review | Splinter Review
(Assignee)

Description

3 years ago
Implement final design of call screen.
(Assignee)

Updated

3 years ago
Assignee: nobody → borja.bugzilla
(Assignee)

Comment 1

3 years ago
Created attachment 8461022 [details] [review]
Pull Request
Attachment #8461022 - Flags: feedback?(rnowmrch)
Setting the corresponding dependencies as this bug blocks all the User Stories included in these meta bugs:
Bug 1002756 - (loop_start_call) [Meta] for Starting Loop Calls from Loop Mobile Client
Bug 1002768 - (loop_receive_call) [Meta] for Receiving Calls in Loop in Loop Mobile Client
Bug 1002763 - (loop_join_calls) [Meta] for Opening URL Callbacks from Loop Mobile Client
Bug 1002774 - (loop_incall_features) [Meta] for In-Call Features in Loop Mobile Client
Bug 1002782 - (loop_post_calls) [Meta] for Post-Call Features in Loop Mobile Client
(Assignee)

Updated

3 years ago
Attachment #8461022 - Flags: ui-review?(vpg)
Attachment #8461022 - Flags: review?(josea.olivera)
(Assignee)

Updated

3 years ago
Attachment #8461022 - Flags: review?(ferjmoreno)
Comment on attachment 8461022 [details] [review]
Pull Request

The CSS part looks good ;)
Attachment #8461022 - Flags: feedback?(rnowmrch) → feedback+
Comment on attachment 8461022 [details] [review]
Pull Request

The JS part looks good to me as well. r=me

I left a few comments on the PR, please address them before landing this. Another thing is that the version is not correctly bumped up. You should have a couple of commits in the PR, the one with the logic being added and the one with the new version. Please ping me in case you have any doubt about the bumping up version mechanism works.
Attachment #8461022 - Flags: review?(josea.olivera) → review+

Updated

3 years ago
Attachment #8461022 - Flags: review?(ferjmoreno) → review+
Comment on attachment 8461022 [details] [review]
Pull Request

As reviewed offline, basic implementation is ok, but a follow up on details is needed. 
Great job!
Attachment #8461022 - Flags: ui-review?(vpg) → ui-review+
(Assignee)

Comment 6

3 years ago
Last bits will be added in the final 'polish' follow up bug. R+ so merging!
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.