1042848 - Whitelist email addresses for actual email on dev and stage

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Kris Maglione [:kmag]]

There are a lot of times when we need to test an email-related feature on dev or stage, but with a limited set of addresses. The most relevant current examples are the bulk validation tool and commbadge. For the latter, at least, simply logging the email is not sufficient.

We should be able to define a whitelisted set of addresses which will receive actual email, even on dev and stage.

Filing for both Marketplace and AMO.

Comment 1

[David Larlet [:davidbgk]]

I created https://github.com/mozilla/olympia/pull/394

We need to coordinate with ops to add the whitelist setting (EMAIL_QA_WHITELIST) to dev/stage private settings.

Comment 2

[Andrew Williamson [:eviljeff]]

out of interest, why choose to implement the change in Olympia in a different manor than in Zamboni?  (Since the original patch its been enhanced further to allow regex on the whitelist [1])

https://github.com/mozilla/zamboni/blob/master/mkt/site/mail.py#L43

Comment 3

[David Larlet [:davidbgk]]

Interesting, I did it without checking zamboni first (my bad). It looked more relevant to me to modify the backend dedicated to dev/stage in order to be sure that it doesn't affect the prod. But it's more a matter of consistency/strategy across both code bases, do we want to have the same behaviors implemented the same ways? For now, it's hard to maintain such symbiosis given that devs from both sides don't push their changes on the other project.

That being said, I should definitely grab the regexp from zamboni :)

Comment 4

[David Larlet [:davidbgk]]

https://github.com/mozilla/olympia/commit/1290474792111b029daba6a9dc3c743f5e6db758

Comment 5

[Madalin Cotetiu]

I couldn't find the  whitelist email addresses settings in here: https://addons-dev.allizom.org/en-US/admin/models/zadmin/config/.
Am I searching in the wrong place?

Comment 6

[Kris Maglione [:kmag]]

Those settings are currently controlled by ops rather than being stored in the DB.

Jason, can you add Madalin's email address to the EMAIL_QA_WHITELIST setting on addons-dev?

Madalin, are there any other addresses which should be added?

Comment 7

[Madalin Cotetiu]

Here are the test accounts that should be added:

[e-mail]
[e-mail]
[e-mail]

Comment 8

[Jason Thomas [:jason]]

I've added the email addresses in comment 7 to EMAIL_QA_WHITELIST for both dev and stage.