Whitelist email addresses for actual email on dev and stage

VERIFIED FIXED in 2014-08-26

Status

Marketplace
General
P4
normal
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: kmag, Assigned: eviljeff)

Tracking

Avenir
2014-08-26
Points:
---
Dependency tree / graph

Details

(Whiteboard: [ReviewTeam])

There are a lot of times when we need to test an email-related feature on dev or stage, but with a limited set of addresses. The most relevant current examples are the bulk validation tool and commbadge. For the latter, at least, simply logging the email is not sufficient.

We should be able to define a whitelisted set of addresses which will receive actual email, even on dev and stage.

Filing for both Marketplace and AMO.
Whiteboard: [ReviewTeam]
Blocks: 855776

Updated

3 years ago
Priority: -- → P4
(Assignee)

Updated

3 years ago
Assignee: nobody → awilliamson
(Assignee)

Comment 1

3 years ago
https://github.com/mozilla/zamboni/pull/2400
(Assignee)

Comment 2

3 years ago
https://github.com/mozilla/zamboni/commit/c09cd09601aeee0ec7e0473d60eeb0932da4b629

QA - 
1) do something that would normally send an email to an address you control on production Marketplace (where REAL_EMAIL setting is True), such as send an info request comment via the reviewer tools, a message via commbadge, etc.  (where you have logged into Marketplace with a different email account)
2) check no emails are received
2) Create the 'real_email_whitelist' config object in https://marketplace.firefox.com/admin/models/zadmin/config/
3) Add the email you used in step 1, and optionally others too (its a comma separated list)
4) Repeat step 1
5) see emails are received this time.
Blocks: 1042848
Status: NEW → RESOLVED
Last Resolved: 3 years ago
No longer depends on: 1042848
Resolution: --- → FIXED
(Assignee)

Comment 3

3 years ago
(In reply to Andrew Williamson [:eviljeff] from comment #2)
> 2) Create the 'real_email_whitelist' config object in
> https://marketplace.firefox.com/admin/models/zadmin/config/

or the equivalent in -dev/stage
(Assignee)

Comment 4

3 years ago
rephrasing QA steps for clarity.
On -dev or stage:
1) using an account [A] with an email you control upload an app and complete it so it enters the review queue.  (or identify an existing upload in the review queue that fits this criteria)
2) using a *different* account [B] do something that would normally send an email, such as send an info request comment via the reviewer tools, a message via commbadge, etc.
3) check no emails are received in [A]'s inbox
4) create the 'real_email_whitelist' config object in https://marketplace-dev.allizom.org/admin/models/zadmin/config/ (or equivalent on stage)
5) Add the email address from account [A], and optionally others too (its a comma separated list)
6) Repeat step 2 - i.e. send an info request, etc, while logged in as account [B]
7) see emails are received this time.
(Assignee)

Updated

3 years ago
Target Milestone: --- → 2014-08-26

Comment 5

3 years ago
Verified as fixed following the steps from comment #4.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.