104286 - Make NSPR's configure script work under MKS Toolkit.

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P2)

Description

[Wan-Teh Chang]

When trying to make NSPR's configure script work under
MKS Toolkit, I discovered three problems.

1. config.guess, config.sub, and configure.in do not
   recognize the values returned by MKS Toolkit's
   uname.  I was able to figure out how to fix this
   problem.  I name the os as "mksnt".  I will attach
   a patch.

2. If sh.exe is not installed in \bin of the current
   drive, configure can't find it.  By examining the
   configure script, I found that this can be fixed
   by setting the environment variable CONFIG_SHELL
   to the pathname of sh.exe or simply to "sh".  That
   is, in the command prompt you would say
       set CONFIG_SHELL=sh
   and in the MKS Korn Shell you would say
       export CONFIG_SHELL=sh

3. The AC_OUTPUT_MAKE_DEFS macro in autoconf 2.13
   assumes that '\012' is the line ending character
   and only translates that to space in confdefs.h.
   The confdefs.h file generated by the MKS Toolkit
   uses Windows CRLF line endings, so '\015' also
   needs to be translated to space.  I am working
   around this by manually editing configure and
   adding
       | tr '\015' ' '
   to the command pipeline.

   By the way, the configure file generated by
   autoconf 2.53 in Cygwin fails miserably under
   MKS Toolkit but works under Cygwin.  Until I
   figure out why, we need to stick with autoconf
   2.13.

Comment 1

[Wan-Teh Chang]

Attachment: Patch to make NSPR's configure recognize MKS Toolkit. [checked in]

Comment 2

[hacker formerly known as [e-mail]]

Comment on attachment 53167 [details] [diff] [review]
Patch to make NSPR's configure recognize MKS Toolkit. [checked in]

r=cls
Please check the config.* changes into the mozilla tree as well.  I'd like to keep them in sync.

Comment 3

[Wan-Teh Chang]

> Please check the config.* changes into the mozilla
> tree as well.

Will do.

Do you know how to locally override the AC_OUTPUT_MAKE_DEFS
macro?  I haven't found a way for GNU make to strip the '\r'
characters in DEFS.

Comment 4

[Wan-Teh Chang]

I checked in the patch (attachment 53167 [details] [diff] [review]) on the tip of NSPR.

I also checked the config.guess and config.sub changes into
mozilla/build/autoconf.

I still haven't figured out a solution for the AC_OUTPUT_MAKE_DEFS
problem.  I am now manually adding "| tr '\015' ' '" to the
autoconf-generated configure script.

Comment 5

[Wan-Teh Chang]

Comment on attachment 53167 [details] [diff] [review]
Patch to make NSPR's configure recognize MKS Toolkit. [checked in]

Chris, do you know how to submit our changes to config.guess
and config.sub (for MKS Toolkit) to the maintainer of
config.guess and config.sub?  This will avoid losing these
changes in a future merging.

Comment 6

[hacker formerly known as [e-mail]]

[e-mail] would be the submission address.  I hope that you have
better luck than I did when I tried to get the msvc changes submitted.

# Please send patches to <[e-mail]>.  Submit a context
# diff and a properly formatted ChangeLog entry.

Comment 7

[Wan-Teh Chang]

MKS support is already in the current autoconf
2.13 release.  Marked the bug WORKSFORME.

Comment 8

[Wan-Teh Chang]

I was wrong.  autoconf 2.13 (both the official one
or the patched version in Red Hat Enterprise Linux 3)
still can't do #3 in comment 0.  #1 is fixed though.

Comment 9

[Christophe Ravel]

The target milestone is already released. Resetting target milestone.

Comment 10

[Kai Engert (:KaiE:)]

Comment on attachment 53167 [details] [diff] [review]
Patch to make NSPR's configure recognize MKS Toolkit. [checked in]

marking patch as checked in as of comment 4

Comment 11

[Wan-Teh Chang]

This bug was left open because I haven't fixed issue 3
in comment 0.  Since we have used the workaround for
years and it doesn't make sense to spend the time coming
up with a proper fix, I'm going to mark this bug fixed.

Comment 12

[Serge Gautherie (:sgautherie)]

(In reply to comment #11)
> This bug was left open because I haven't fixed issue 3
> in comment 0.

I filed bug 480680.